feat: Event manager - #12
Open
joren-dev wants to merge 7 commits into
Open
Conversation
joren-dev
requested review from
Michielo1,
Peter-The-Great,
SyncMQ,
keesvv and
lhridder
February 6, 2023 22:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a basic way to add events, I am thinking of implementing this concept.
When someone wants to add a feature, based on an event they have to do the following.
on_message(OnMessageEvent) event./events/print_message.pywithin the
on_message, one can do call and do anything they wish. The params will match the original event, to ensure you have the same functionality.Then in
EventManagerone has to register their feature:And thats it, whatever they have written inside their
on_messagemethod will be ran the moment the event is called.This is how it works behind the scenes:
Essentially just iterates over all the objects and calls the event method that we defined ourselves.