chore: use Effect Console in nesting validator#47
Merged
Conversation
warnIfInvalidNesting now returns Effect<void> and uses Console.warn instead of raw console.warn. Both renderers' appendChild yield* the warning inside Effect.gen. Consistent with the equivalent changes in @effex/platform and @effex/dom's subscribeReconcile — Effect Console goes through a Layer-swappable service and matches the codebase's overall paradigm. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Deploying effex with
|
| Latest commit: |
3700f21
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2560d993.effex.pages.dev |
| Branch Preview URL: | https://chore-nesting-effect-console.effex.pages.dev |
Deploying effex-api with
|
| Latest commit: |
3700f21
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f347be7f.effex-api.pages.dev |
| Branch Preview URL: | https://chore-nesting-effect-console.effex-api.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up on the merged PR #42 (invalid HTML nesting warnings) — swap raw `console.warn` for Effect's `Console.warn`.
Why
Same rationale as the equivalent change in `@effex/platform` (#46) and `@effex/dom`'s `subscribeReconcile` (#45). Every log site is inside an `Effect` chain via the renderer's `appendChild`, so Effect's `Console` is the idiomatic choice: runs inside the fiber, no `Effect.sync` wrapping, and Layer-swappable for tests.
Changes
Test plan
🤖 Generated with Claude Code