Report injection-family holdout and provenance limits - #2
Merged
Conversation
Owner
Author
|
Verification and review note:
No rule, taxonomy, corpus, label, canonical split, or dependency changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The canonical
(suite, user task, injection task)group key prevents exact combinations from crossing partitions, but every injection-task identity appears in both development and holdout. Its 35.3% recall therefore measures generalisation to unseen combinations, not unseen attacks.The dominant empirical finding is broader than TW-001: eight of eleven canonical holdout false negatives carry attacker-controlled strings inside transaction records returned by tools classified as internal. Tool-result-level provenance cannot represent mixed-trust records accurately.
Measured impact
The canonical result remains unchanged:
The secondary family-isolated split deterministically holds out
injection_task_7andinjection_task_8and recalls 6/13 successful attacks, or 46.2% (Wilson 95%: 23.2%–70.9%). This is higher than the canonical result, not lower.Methodology caveat
The family result is explicitly reported as a post-hoc stress test, not an unbiased unseen-attack estimate. TW-001 was frozen before this analysis, but its original development partition contained examples from every injection family.
False-positive finding
Two of three development false positives are benign
none/none.jsonsessions. The remaining development false positive and the holdout false positive are injected runs whose benchmark goals failed. All four share the legitimate sequenceread_file → get_scheduled_transactions → update_scheduled_transaction, establishing an honest specificity ceiling for this rule shape.Scope
No rule, taxonomy, corpus, label, canonical split, or dependency changed. No additional rule was added.
Verification
uv run tripwire verify: TP 6, FP 1, TN 36, FN 11pytest: 29 passedmypy: passedruff check .: passeduv build: source distribution and wheel builtgit diff --check: passedReview
A fresh read-only reviewer approved the family-split methodology and reporting. Its one blocking documentation-accuracy finding was fixed, and the requested regression coverage now asserts the exact benign source entries and common tool sequence across all four false positives.
Review guidance
Focus on whether the family stress test is clearly distinguished from a clean holdout and whether the README gives the provenance finding appropriate prominence without overstating generalisation.