ADR-277: Refactor Step protocol — get_actions/handle_results + ParallelSteps#32
Merged
jodavis merged 4 commits intoJun 12, 2026
Conversation
build-and-test: Python test resultsStatus: ✅ Passed Test log |
jodavis
changed the base branch from
main
to
feature/ADR-269-agent-orchestration
jodavis
requested changes
Jun 12, 2026
jodavis
left a comment
jodavis
left a comment
Owner
There was a problem hiding this comment.
I like the direction this is going. It's much cleaner than the previous implementation. There are a few things that would make it even better.
- Delete Step.run() shim - Remove redundant print() status calls from step methods - Remove results parameter from handle_results() and --results CLI arg - Split reviewing state into creating-pr + reviewing; delete _REDISPATCH - Make combine_results abstract on ParallelSteps - Update workflow files and dev-team.md orchestration docs accordingly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Increment the version in the plugin JSON file for the dev-team plugin by 0.0.1 in each task.
jodavis
added a commit
that referenced
this pull request
Jun 19, 2026
…elSteps (#32) * ADR-277: uncommitted changes at validation * ADR-277: Address PR review comments - Delete Step.run() shim - Remove redundant print() status calls from step methods - Remove results parameter from handle_results() and --results CLI arg - Split reviewing state into creating-pr + reviewing; delete _REDISPATCH - Make combine_results abstract on ParallelSteps - Update workflow files and dev-team.md orchestration docs accordingly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Bump dev-tools version from 1.2.1 to 1.2.2 * Increment plugin version in dev-team plugin JSON Increment the version in the plugin JSON file for the dev-team plugin by 0.0.1 in each task. --------- Co-authored-by: Joe Davis <ElwoodMoves@hotmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Joe Davis <jodasoft@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_actions() -> list[dict]andhandle_results(results) -> strabstract methods onStep; deprecatesrun()withNotImplementedErrorParallelStepscomposite that concatenates children's actions and splits results back by count, with configurablecombine_results()precedenceSignoffStepintoReviewerSignOffStep,ResearcherSignOffStep, andBuildValidationStepcomposed viaParallelSteps--resultsCLI argument todev_team.py; updatesdev-team.mdto pass results back on each invocationParallelSteps, inline step dispatch, infinite-loop guard, and--resultsparsingTest plan
pytest plugins/dev-team/scripts/test_dev_team.pypassesTestParallelStepsGetActions— flat action list equals concatenation of childrenTestParallelStepsHandleResults— split by action count;combine_resultsprecedence (failed>changes_requested> first)TestInlineStepDispatch— inline step advances withoutexit_with_actions; infinite-loop guard firesTestResultsParsing—--resultscomma-split and whitespace stripping🤖 Generated with Claude Code