Repository navigation
Conversation
joblib#250 restricted the dllist import to Linux with Python 3.15+, so Windows and macOS on Python 3.14+ fell back to the older listing code. Restore the 3.7.0 behavior there and keep the Linux restriction. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 29, 2026
Closed
itamarst
approved these changes
Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#250 changed the
dllistimport condition tosys.platform == "linux" and sys.version_info[:2] >= (3, 15). Windows and macOS on Python 3.14+ therefore stopped usingctypes.util.dllist, which 3.7.0 used there (#219), and fell back to the older listing code. This looks unintended: #250 is only about Linux. This PR restores the 3.7.0 behavior on Windows and macOS and keeps the Linux restriction.The new test fails on master and passes with this PR on macOS with Python 3.14. The PR also drops the
stdlib_dllist()test helper, which still mirrored the 3.7.0 condition and wrongly skipped a Windows test.This regression hasn't been released, so there is no changelog entry.
🤖 Generated with Claude Code