Repository navigation
Conversation
Contributor
Author
|
Oops my agent opened the PR before I had a chance to review it locally... This was not intended. Let me review it first. |
ogrisel
marked this pull request as draft
October 29, 2026 17:22
ogrisel
commented
Oct 29, 2026
ogrisel
left a comment
ogrisel
left a comment
Contributor
Author
There was a problem hiding this comment.
Self review to chat with my agent.
ogrisel
commented
Oct 29, 2026
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Cursor <cursoragent@cursor.com>
ogrisel
commented
Oct 29, 2026
ogrisel
commented
Oct 29, 2026
ogrisel
marked this pull request as ready for review
October 29, 2026 18:10
Contributor
Author
|
I think this is ready for review @itamarst. It seems like a real bugfix to me. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_cached_controller()read_CACHED_CONTROLLERtwice on the fast path (and again after releasing the lock on the slow path).reset_cached_controller()and FlexiBLAS backend loads set that global to None, so a concurrent caller could observe None and crash on.limit().Test plan
get_cached_controller()/reset_cached_controller()stress testMade with Cursor