fix(web): add favicon set — /favicon.ico no longer 404s (SQLR-72)#171
Merged
Conversation
Adds the Next 15 app-dir icon files: icon.svg (the orange play-glyph brand mark from og.tsx / .brand-mark), favicon.ico (16/32/48 PNG-in-ICO raster so direct /favicon.ico requests return 200), and apple-icon.png (180x180 full-bleed for iOS). Documents the favicon surface and the regeneration path in web/README.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web/src/app/:icon.svg(the orange#f97316play-glyph brand mark, matchingog.tsxand.brand-mark),favicon.ico(16/32/48 PNG-in-ICO so direct/favicon.icorequests return 200 — anicon.svgalone only emits the link tag), andapple-icon.png(180×180 full-bleed; iOS applies its own corner mask).web/README.md.Fixes SQLR-72 (site-wide
/favicon.ico404, surfaced while verifying SQLR-42).Test plan
npm run buildcleannpm run typecheckcleannpm run lint— only the pre-existing<img>warning inexamples/page.tsxnext start -p 3001:/favicon.ico→ 200image/x-icon,/icon.svg→ 200image/svg+xml,/apple-icon.png→ 200image/png<link rel="icon">+apple-touch-icontags present in rendered HTML on/and/docs🤖 Generated with Claude Code