Repository navigation
Conversation
…figures and diagrams set as their standards print them The weighted vibration severity KB is italic in every diagram, figure, guide, docstring and errata entry, as DIN 4150-2 and DIN 45672 print it, and Euler's number is upright in every formula, as ISO 80000-2:2019 prints the mathematical constants. `make subscripts` fails on an upright KB and `scripts/check_euler_number.py` fails on an italic e, and both checks now read the row breaks, wrapped inline math and escaped strings they used to skip. The EN 15657 symbols, the standardized levels with their italic T, the ISO 7235 diagram with its sign put right, and the noise control, in-situ, exposure, aircraft and theory symbols follow their printed pages. No public name, signature or return value changes.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
jmrplens
added this pull request to stack #955
October 8, 2026 07:01
|
Important Review skippedToo many files! This PR contains 436 files, which is 336 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configuration
⛔ Files ignored due to path filters (204)
📒 Files selected for processing (436)
You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
documentation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #952 +/- ##
=======================================
Coverage 96.80% 96.80%
=======================================
Files 443 443
Lines 88771 88774 +3
=======================================
+ Hits 85933 85936 +3
Misses 2838 2838 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Numerical conformance
1893/1893 checks pass across 111 domains and 523 standards (227 normative designations, 125 further published sources). Used in the tables below is how much of that clause's published tolerance the deviation consumes: 100 % sits exactly on the limit, 5 % uses a twentieth of the allowance, and a dash means the clause states no two-sided tolerance for the quantity, so there is no budget to spend. It is reported and never used to decide a verdict, which is settled at full precision before any rounding. Nothing moved: same 1893 checks, same verdicts, same numbers. Closest to their published limit (top 5) The rows with the least room left, so the ones a change is most likely to push over.
|
| Python Version | Tests | Failures | Coverage | Status |
|---|---|---|---|---|
| macos-latest-3.13 | 27128 | 0 | 96.8% |  Passed |
| macos-latest-3.14 | 27128 | 0 | 96.8% | Passed |
| ubuntu-latest-3.13 | 27128 | 0 | 96.8% | Passed |
| ubuntu-latest-3.14 | 27128 | 0 | 96.8% | Passed |
| windows-latest-3.13 | 27128 | 0 | 96.8% | Passed |
| windows-latest-3.14 | 27128 | 0 | 96.8% | Passed |
Full report at this commit: docs/CONFORMANCE.md · docs/conformance.json · full CI artifacts
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weighted vibration severity KB is one quantity symbol of two letters, and DIN 4150-2:1999, E DIN 4150-2, DIN 45672-2 and E DIN 45672-3 print it italic. The diagrams drew it upright, as an acronym, and the immission guides named the KB family as code. Every diagram, figure, guide (English, Spanish and the docs mirror), docstring and errata entry now sets it italic, and
make subscriptsfails on an upright KB anywhere it reads, embedded images included.Euler's number is upright in every formula, as ISO 80000-2:2019 prints the mathematical constants, and the base of the natural logarithm is written$\log_\mathrm{e}$ as item 2-13.5 prints it. The site used to set about seventy italic and forty upright e, sometimes a few lines apart on one page.
scripts/check_euler_number.py, run bymake euler-numberand by its own CI job, reads every formula of the docstrings, the guides, the docs mirror, the theory pages and the errata register, and the label source of every figure and diagram, and fails on an exponent hung on an italic e or on an italic base of the logarithm.The two checks used to skip some formulas without saying so: a block with a row break
\\(everycasesandalignedblock), a formula opened by(\deltaor(\dfrac, inline math that wraps onto the next line of a page, and the doubled backslashes of a plain Python string. They read all of those now, and they found twelve more italic e and two subscripts that lagged their page, which are fixed.The EN 15657 symbols are set as UNE-EN 15657:2018 prints them, every subscript upright, the letter of the quantity included ($L_\mathrm{Ws}$ , $L_\mathrm{Fb,eq}$ , $L_\mathrm{v,i}$ , $Y_\mathrm{R,low,eq}$ ), and the EN 12354-5 page and module write the power levels the same way. The glossary card of the structure-borne power level printed "Wmathrm" as text; it reads $L_\mathrm{Ws}$ again.
Every subscripted symbol of the guides, their diagrams and their figures was listed, and the symbols of the aircraft, building, device, noise control, environment and theory pages were checked against their standard's printed page. Where a print sets some letters italic and others upright the documentation now follows it exactly; where a print sets every subscript one way, abbreviations the page expands are upright and letters it does not expand stay italic, as CONTRIBUTING asks. The changes a reader will see:
The diagram canvas can now split a subscript letter by letter under one symbol only, so the series level$L_{p\mathrm{I}}$ of ISO 7235 sets an upright I while the pressure-intensity indicator $F_{pI}$ of ISO 9614 keeps both letters italic.
No public name, signature or return value changes, so there is nothing to migrate. Only symbols in docstrings, plot labels, report fiches and documentation move; the strings a result reports itself under, such as
SilencerInSituResult.symbol, are unchanged.Open for a decision: IEC 60534-8-3 prints every subscript of the control valve noise method upright, and the guide keeps the letters it does not expand italic, as the corpus rule asks; the errata entries that transcribe EN 12354-2 and -3:2000 keep the all-italic$D_{2m,nT}$ those prints use.
Verification:
ruff check .,ruff format --check .,mypy src scripts(689 files) andbandit -q -r srcpass. The full suite passes (27059 passed, 69 skipped), every documentation snippet runs (7488 blocks over 730 pages), and the site type-checks with 0 errors, builds its 987 pages and passes html-validate.make subscriptsandmake euler-numberpass, as do the API reference, conformance, errata evidence, markdown, digit grouping, mathtext, docstring math, frozen constant, parameter unit, Spanish accent and em dash checks. Every figure and fiche was regenerated from this tree: the 3312 committed figures and 77 fiches match their generators, and the figure language, annotation, tick, legend, text and tick clearance, contrast, minus sign and decimal point checks report nothing; the 43 published clips still match the code that draws them. I looked at the changed diagrams and figures in both languages: the series levels and the corrected sign on the ISO 7235 diagram, the in-situ formulas, the axis values of the exposure diagrams, the stage support legend, the standardized level in the service equipment title and the Spanish annotation of the structure-borne conversion figure, which now stays clear of the curve. The new canvas test fails without the per-symbol table, and the eight checker tests fail on the tree before the checks were widened.