Repository navigation
Reject calls matched by invalid RPC responses - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A malformed response with an ID matching an in-flight call reported a protocol error but left that call pending forever. Reject the matched call before reporting the diagnostic, so it settles even when the diagnostic callback throws; unrelated calls and the session remain usable.
Validation:
npm run fmt:checknpm run lint(passes with three pre-existing unused-import warnings inwebsocket.test.ts)npm run buildnpm run test(164 tests)Independent review found no issues after checking matching and non-matching IDs, a throwing diagnostic callback, pending-call cleanup, and continued session use.