Skip to content

fix: trailing decimal point drops the following unit #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dy merged 1 commit into from
Sep 28, 2026
Merged

fix: trailing decimal point drops the following unit #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import en from './locale/en.js'

const durationRE = /((?:\d+(?:\.\d+)?|\.\d+)(?:[eE][-+]?\d+)?)\s*([\p{L}]{0,14})/gu
const durationRE = /((?:\d+(?:\.\d*)?|\.\d+)(?:[eE][-+]?\d+)?)\s*([\p{L}]{0,14})/gu

parse.unit = en

Expand Down
10 changes: 10 additions & 0 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,16 @@ t('edge cases', t => {
t.end()
})

t('trailing decimal point with no fraction digits', t => {
// a bare `.` right after the integer part must not swallow the unit
// that follows it, e.g. "5. seconds" should behave like "5 seconds"
t.equal(parse('5. seconds'), 5 * s)
t.equal(parse('5.seconds'), 5 * s)
t.equal(parse('5. secs'), parse('5 secs'))
t.equal(parse('-5. secs'), -5 * s)
t.end()
})

t('invalid', t => {
t.equal(parse('abc'), null)
t.equal(parse(), null)
Expand Down
Loading