Skip to content

make it first destination OR service#1396

Closed
that70schris wants to merge 1 commit into
newjitsufrom
feat/destinations-or-services
Closed

make it first destination OR service#1396
that70schris wants to merge 1 commit into
newjitsufrom
feat/destinations-or-services

Conversation

@that70schris

Copy link
Copy Markdown
Contributor

No description provided.

@jitsu-code-review jitsu-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes in around first-object activation tracking. The destination+service combined count logic looks correct and I didn’t spot correctness, security, or user-visible regression issues in this diff.

@jitsu-code-review jitsu-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes in webapps/console/lib/server/config-objects-service.ts around first-object activation tracking. The destination+service combined count logic looks correct and I did not spot correctness, security, or user-visible regression issues in this diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant