Skip to content
This repository was archived by the owner on Oct 11, 2018. It is now read-only.

when enabling sql extensions, enable their pdo counterparts#116

Open
igalic wants to merge 2 commits into
jippi:masterfrom
igalic:pdo
Open

when enabling sql extensions, enable their pdo counterparts#116
igalic wants to merge 2 commits into
jippi:masterfrom
igalic:pdo

Conversation

@igalic

@igalic igalic commented Dec 22, 2014

Copy link
Copy Markdown
Collaborator

n.b.: all mysql extensions point to the same pdo name/file.
for mysql in particular, we also enable mysqli

@igalic

igalic commented Dec 22, 2014

Copy link
Copy Markdown
Collaborator Author

this doesn't do much, as of yet.
it's almost like something is missing. so strange, even though our settings are [ ] :P

Comment thread manifests/link_extension.pp Outdated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may want to remove this :)

don't think many people uses supervisor - in my case its used to reload all php workers processes

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that said, being able to subscribe to these enable/disable execs is very useful

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nod
notify/subscribe are metaparameters, you can always pass them along.

@igalic

igalic commented Feb 17, 2015

Copy link
Copy Markdown
Collaborator Author

i think it's time i take another look at this ;)

@jippi

jippi commented Feb 17, 2015

Copy link
Copy Markdown
Owner

haha yeah

@igalic

igalic commented Feb 17, 2015

Copy link
Copy Markdown
Collaborator Author

so! I just tested this on one of my prod systems and it seems to work out fine.

next step should be to move the standard php::config case into php::extension, and remove all params classes.

@jippi

jippi commented Feb 18, 2015

Copy link
Copy Markdown
Owner

nizzle ! :)

@igalic

igalic commented Feb 18, 2015

Copy link
Copy Markdown
Collaborator Author

i'd love to get some more feedback / testing here ;)

@igalic

igalic commented Feb 19, 2015

Copy link
Copy Markdown
Collaborator Author

latest commit uses the correct prio for mysqlnd, not sure about the other drivers. again: need some feedback / testing from other people ;)

*always* symlink extension to all (enabled) SAPIs

all (both) mysql extensions point to the same pdo name/file. For
mysql(nd) also manage mysqli inifile/settings
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants