Repository navigation
feat(data): push read filters to Doris and ClickHouse - #134
Merged
Merged
Conversation
Forward supported leading structured filters through the native Ray connectors and retain ordered residual execution with receipt decisions. Add owned single-node database validation with SQL execution evidence and document supported predicates and the Ray Unicode residual limit. Signed-off-by: jiangxt2 <jiangxt2@vip.qq.com>
[Medium impact] The PR appears safe to merge; no actionable issues were identified. SummaryAdds source-side filtering for supported leading transforms in the Ray ClickHouse and Doris bindings.
|
Select canonical digest-pinned runtime and database images on hosted runners while retaining the local mirror default. Verify source selection and digest validation without weakening the database evidence gate. Signed-off-by: jiangxt2 <jiangxt2@vip.qq.com>
Replace the pending hosted execution note with verified Linux amd64 database CI evidence while retaining the single-node support boundary. Signed-off-by: jiangxt2 <jiangxt2@vip.qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Forward supported leading structured filters from
IngestionRequest.transformstoray-dorisandray-clickhouse, allowing the database to exclude rows before returning them to Ray. For the 10,000-row validation fixture,id >= 9900returns 100 rows from the native reader and produces the same final result as Ray-side filtering.database-filter-gatecheck, unit and contract coverage, and user documentation.Related issues
Fixes #133.
Upstream dependency limitation: ray-project/ray#67230.
Additional information
Validation
uv run --locked --no-sync python scripts/pr-precheck.pypassed, including the complete CI unit suite in isolated dev-only Python 3.12 and 3.13 environments and the documentation static, strict-build, and spelling checks. Six non-blocking inline-import warnings in test helpers were reviewed../scripts/run_database_filter_it.sh --database clickhouse: 22 tests passed without skips against ClickHouse 26.8.1.2041, covering single, physical-partition, and integer-range reads../scripts/run_database_filter_it.sh --database doris: 21 tests passed without skips against Doris 4.0.6, covering MySQL and Flight reads.ray-clickhouse==1.1, andray-doris==1.3. It verifies successful real-driver SQL execution, bound values, a reduction from 10,000 baseline rows to 100 native output rows, equivalent final rows and schema, and no residual Ray filter for the exact predicate.Scope and limitations
Public input shapes and dependency versions are unchanged. The scope is bounded table reads through these two Ray bindings. Unsupported predicates and filters after a transform barrier retain ordered Ray execution; arbitrary SQL, other connectors, Daft, and writes are outside this change. Single-node evidence does not establish multi-node behavior, index pruning, or a performance speedup.
Ray 2.59.0 residual filters containing Unicode literals can fail with
UnicodeEncodeErrorin operator metric tags, as tracked above. Exact source execution avoids the corresponding Ray Filter, but residual expressions remain affected. The read guide and support matrix document this dependency limitation; this change does not modify Ray or reorder transforms to avoid it.