Skip to content

Timeout unit not specified #450

Open
Open
Timeout unit not specified#450

Description

@kayscheerer
kayscheerer
opened on Jun 29, 2026

https://github.com/jfrog/artifactory-client-java/blame/631eafcb125bf0b1f2fd562fa474008bbd0ddb46/services/src/main/groovy/org/jfrog/artifactory/client/ArtifactoryClientBuilder.java#L74

There is little to no code documentation and the variable names are also not speaking for themselves. What are the units for the timeout?
Seconds? Milliseconds?

Activity

  1. rnc commented on Aug 5, 2026

    @rnc
    rnc
    on Aug 5, 2026

    I think they are in milliseconds as this uses Apache HTTPClient 4.x ( https://github.com/jfrog/artifactory-client-java/blob/master/build.gradle#L80 )

  2. kayscheerer commented on Aug 5, 2026

    @kayscheerer
    kayscheerer
    on Aug 5, 2026
    Author

    yes, I figured that out after looking at the source code as well.
    I would say it could be improved 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions