Repository navigation
docs(spec): name the vendored input handler, not ghostty-web, in the key-binding and zoom paths - #54
Merged
Merged
Conversation
…key-binding and zoom paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wording only. After ADR 041 and ADR 047, webtty no longer depends on the npm
ghostty-webpackage. Its terminal is the official libghostty-vt engine, with a renderer and input layer vendored from ghostty-web and heavily modified. Several spec passages still said "ghostty-web" handles keys, as if the npm package did the input.docs/specs/client.md: the Keyboard Bindings and font-zoom passages and the Terminal view feature row.docs/specs/key-bindings.md: the Description and Client implementation passages.These passages now say "the terminal's input handler (vendored from ghostty-web, encoding keys with libghostty-vt's key encoder)" and name
features/keyboard/key-dispatcher.ts. The README, the licence files and the passages describing the vendored layer itself are unchanged, because they were already accurate.