Repository navigation
fix(client): revert the page-zoom wheel classification that made trackpad and TrackPoint scrolling laggy - #50
Merged
Merged
Conversation
…ackpad and TrackPoint scrolling glide like a wheel This reverts commit afd2858. With the page zoom read as other than 100%, the deltas scaled by it and compared by a ratio within 1% were taken for wheel notches, so every delta got the wheel's 125 ms glide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts afd2858 (released in 2.0.0), which made trackpad and TrackPoint scrolling laggy.
That change scaled wheel deltas by a page zoom estimated from
outerWidth / innerWidth, and compared notches by a ratio within 1% of a whole number. Together, with the zoom read as other than 100%, a trackpad's or TrackPoint's deltas were taken for mouse wheel notches, so every delta got the wheel's 125 ms ease-out glide. Each half alone was verified smooth; the build before afd2858 was verified smooth in Chrome.The revert brings back the earlier gap noted in ADR 045: at a browser zoom other than 100%, some mouse wheel notches are classified as a sparse (TrackPoint) stream and glide linearly. A zoom fix that does not misread the zoom will follow separately.
Verified: unit tests (3083), lint, coverage targets and the architecture check pass.
ADRs