Fix dead dshm.tmsimg.com image host, add plugin.json manifest - #5
Closed
kilo-WATT wants to merge 1 commit into
Closed
Fix dead dshm.tmsimg.com image host, add plugin.json manifest#5kilo-WATT wants to merge 1 commit into
kilo-WATT wants to merge 1 commit into
Conversation
Fixes jesmannstl#3 Gracenote retired the dshm.tmsimg.com image CDN subdomain (NXDOMAIN, confirmed against public resolvers), so every <programme> <icon> in the generated XMLTV points at a dead host — Jellyfin logs thousands of "Unable to pre-cache" warnings and Live TV guide thumbnails never load. - zap2xml.py: swap the two hardcoded dshm.tmsimg.com references (~line 481, ~line 499) to demo.tmsimg.com, which resolves and serves the identical /assets/pXXXX_*.jpg paths (verified: HTTP 200). This is a recurring problem (zap2it.tmsimg.com -> dshm.tmsimg.com was an earlier rotation) — a config field or API-derived host would avoid the next hardcoded-host rot, but out of scope for this fix. - Add plugin.json (generated from the plugin's own fields/actions), which clears Dispatcharr's "legacy plugin, please add plugin.json" warning. The plugin currently ships with no manifest at all. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Author
|
Folded into #4 — didn't need to be a separate PR, both fixes were found in the same debugging session. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
Summary
zap2xml.pyhardcodes the Gracenote image CDN hostdshm.tmsimg.comin two places. That host no longer resolves (NXDOMAIN, confirmed against1.1.1.1), so every<programme><icon>in the generated XMLTV points at a dead host — downstream media servers (Jellyfin, in my case) can't fetch any program thumbnails and log thousands of failed pre-cache warnings per guide refresh.This is a recurring problem: the code already migrated once before (
zap2it.tmsimg.com→dshm.tmsimg.com), and nowdshmitself is dead.Changes
zap2xml.py(~line 481, ~line 499): swap the twodshm.tmsimg.comreferences todemo.tmsimg.com, which resolves and serves the identical/assets/pXXXX_*.jpgpaths.dig +short @1.1.1.1 dshm.tmsimg.com→ no answer (dead)dig +short @1.1.1.1 demo.tmsimg.com→ resolves (CloudFront)curl -I https://demo.tmsimg.com/assets/p410078_b_v13_am.jpg→200 OK, same asset path patternplugin.json(new file, added to the zip alongsideplugin.py): generated from the plugin's ownfields/actions. The plugin currently ships with no manifest, so Dispatcharr flags it as a legacy plugin ("Please update or ask the developer to add plugin.json"). This clears that warning.Test plan
Both changes have been running in production on a live Dispatcharr instance for about a week:
demo.tmsimg.comresolves reliably and thumbnails load correctly in Jellyfin's Live TV guide (no moreUnable to pre-cachewarnings), andplugin.jsonclears the legacy-plugin warning in Dispatcharr's plugin UI with no other behavior change.(This repo ships the plugin as
zap2xml.ziprather than loose files, so a rawgit diffon the zip isn't reviewable in GitHub's UI — the changes are the 3-line host swap plus the one newplugin.jsonfile described above;plugin.py,channels.db, and__init__.pyare untouched. Kept independent of #4 so it can be reviewed/merged on its own.)🤖 Assisted by Claude Code