Gln/diff alignment fixes ouvv#340
Merged
Merged
Conversation
…icts Dotted blue line indicators in the diff gutter were showing at stale line numbers when viewing a different commit, because the lookup used raw comment.line values from the store instead of the re-anchored positions computed by resolveCommentLineFromDiffHunk. Also fixed React warnings about mixing background shorthand with individual background-* properties, and added a missing useMemo dependency to prevent stale inline-change highlighting.
When two candidate inserts have nearly identical content-change ratios (within 0.05), prefer the one closer in the changes array. This prevents semantically-different lines like `def top_append` from pairing with `def top_setattr` across the hunk, when the correct same-function neighbor exists at a similar ratio. Also fix detectAndUnpairCrossings to sort pairs by newLineNumber and check old-line-number inversions, matching the visual emitLines order so the correct pair is unpaired in crossing scenarios.
glehmann
force-pushed
the
gln/diff-alignment-fixes-ouvv
branch
from
dafd445 to
5a240ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.