fix: skip cross-origin requests in Service Worker#336
Merged
Conversation
Add URL guard so cross-origin requests (api.github.com/graphql) bypass the SW entirely, preventing CORS errors caused by the SW re-issuing CORS fetches. Also handle cache-miss gracefully with a 503 fallback response. Resolves #332
On mousedown on one side, set the opposite side's elements to user-select: none. The protection persists until the next mousedown (which clears it), preventing the browser from extending the selection across sides after mouseup.
…view syntax highlighting - Remove change-index distance bound in findBestInsertForDelete so indentation-only changes pair across block replacement boundaries - Collect unpaired inserts separately and sort all output by new-line position, producing monotonic line numbers in unified view - Estimate delete positions from the next paired line's new-line number, placing delete-only lines at their context-appropriate position - Add second pairing pass after crossing detection to re-pair content-similar lines that crossing unpairing broke apart - Merge adjacent empty delete+insert lines into a single normal line - Stop re-diffing in split-view convertToSplitPairs; filter original segments by type instead, preserving syntax-highlighted HTML
The 3px left border for inline-change lines was blue, clashing with the yellow row background. Changed --code-changed from blue.500 to yellow.500.
glehmann
force-pushed
the
gln/fix-diff-rendering-logic-qzro
branch
from
a3a19c0 to
316c898
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add URL guard so cross-origin requests (api.github.com/graphql)
bypass the SW entirely, preventing CORS errors caused by the SW
re-issuing CORS fetches. Also handle cache-miss gracefully with a
503 fallback response.
Resolves #332