Remove build-host CPU variants - #6
Merged
Merged
Conversation
AVX2 cut isolated scanner time by 35-41% on Zen 3 and Zen 4, but production decode and encode showed no consistent gain outside BEAM benchmark drift. Ship 30 portable artifacts and remove the build-host probes and duplicate wide loops instead of adding runtime unsafe dispatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance decision
A four-leg baseline / AVX2 / x86-64-v3 / baseline comparison ran through Criterion and the production decode and encode APIs on AMD Zen 3 and Zen 4 hosts. AVX2 reduced isolated scanner time by about 35-41%, but decode and encode showed no consistent end-to-end gain outside BEAM benchmark drift. The result does not justify carrying runtime dispatch and an unsafe target-feature boundary.
Benchmark evidence: https://github.com/jeffhuen/RustyCSV/actions/runs/31866641117
Verification