Conversation
`jbang wrapper install` copies the launcher scripts and the jar with COPY_ATTRIBUTES, which carries over the timestamps of the JBang installation they come from. For a released JBang those timestamps come out of its distribution archive, and since the build enables reproducible builds Gradle stamps every entry with its fixed 1980-02-01 constant. Every generated wrapper therefore looked like it was last modified in 1980. Keep copying the attributes, so the scripts stay executable, and set the modification time of each copy to the current time right after. Fixes jbangdev#300 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jbang wrapper installcopies the launcher scripts and the jar with COPY_ATTRIBUTES, which carries over the timestamps of the JBang installation they come from. For a released JBang those timestamps come out of its distribution archive, and since the build enables reproducible builds Gradle stamps every entry with its fixed 1980-02-01 constant. Every generated wrapper therefore looked like it was last modified in 1980.Keep copying the attributes, so the scripts stay executable, and set the modification time of each copy to the current time right after.
Fixes #300