Skip to content

Fix RDS parameter group convergence #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaydreyer merged 1 commit into from
Aug 14, 2026
Merged

Fix RDS parameter group convergence #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions infra/terraform/environments/demo/database.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ resource "aws_db_parameter_group" "postgres17" {
family = "postgres17"

parameter {
name = "rds.force_ssl"
value = "1"
apply_method = "pending-reboot"
name = "rds.force_ssl"
value = "1"
}

tags = {
Expand Down
8 changes: 8 additions & 0 deletions infra/terraform/environments/demo/tests/architecture.tftest.hcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,14 @@ run "adr_0022_off_state" {
error_message = "RDS deletion protection must be enabled by default."
}

assert {
condition = alltrue([
for parameter in aws_db_parameter_group.postgres17.parameter :
parameter.name != "rds.force_ssl" || parameter.apply_method == "pending-reboot"
])
error_message = "The static rds.force_ssl parameter must use pending-reboot so Terraform converges after creation."
}

assert {
condition = aws_ecs_task_definition.application.cpu == "1024" && aws_ecs_task_definition.application.memory == "2048"
error_message = "The application task must retain the approved 1 vCPU / 2 GiB size."
Expand Down
Loading