Skip to content

mono - chore: set Node baseline to 24#1671

Merged
jaredwray merged 1 commit into
mainfrom
claude/cacheable-dependency-management-d6gb1r
Jul 5, 2026
Merged

mono - chore: set Node baseline to 24#1671
jaredwray merged 1 commit into
mainfrom
claude/cacheable-dependency-management-d6gb1r

Conversation

@jaredwray

Copy link
Copy Markdown
Owner

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines and Code of Conduct
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage. — N/A: config + dependency change with no source changes; existing suites still pass at 100% coverage where runnable in this environment.

What kind of change does this PR introduce?

Maintenance (chore) — raises the development/release Node baseline to 24 and moves @types/node to the latest 24.x, per maintainer decision. Resolves the earlier .nvmrc (22) vs @types/node (^24) mismatch by raising the baseline rather than pinning the types down.

Versions

  • .nvmrc 2224
  • @types/node ^24.12.2^24.13.2 (latest 24.x permitted by minimumReleaseAge)

Notes

  • The CI test matrix is intentionally left at 22 / 24 / 26 — no change to .github/workflows/.
  • Consumer-facing engines.node are unchanged (cacheable-request >=18, @cacheable/node-cache >=22), so published packages keep supporting older Node; only the dev/release baseline moves.
  • release.yml reads node-version-file: .nvmrc, so releases will now build on Node 24.

Verification

  • pnpm build passes

  • node scripts/test-build.mjs (build-output validation: runtime + publint + attw) passes for all packages

  • pnpm test — every package passes at 100% coverage except the same 3 tests that fail on main and are specific to this sandbox (not caused by this change):

    • cacheable-request › return with url and port — real request to external mockhttp.org:8080, unreachable here (the :80 variant passes).
    • file-entry-cache › should return a file descriptor with checksum and error and normalizeEntries() › should return all entries — both chmod 0o000 a file to force a read error, but this sandbox runs as root, which bypasses permission bits.

    All three pass on GitHub CI (non-root runner, full network).


Generated by Claude Code

Raise the development/release Node baseline to 24 and bump @types/node to
the latest 24.x, per maintainer decision. The CI test matrix stays at
22/24/26 and consumer-facing engines.node are unchanged, so published
packages keep supporting older Node.

- .nvmrc 22 -> 24
- @types/node ^24.12.2 -> ^24.13.2 (latest 24.x under minimumReleaseAge)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01P1TBuMiXotBjpNHYcbwvqf

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Node.js version in .nvmrc from 22 to 24 and upgrades the @types/node dependency in package.json and pnpm-lock.yaml from version 24.12.2 to 24.13.2. There are no review comments, and I have no feedback to provide.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​types/​node@​24.13.21001008196100

View full report

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b5a4515) to head (b3305c1).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1671   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         3504      3504           
  Branches       808       796   -12     
=========================================
  Hits          3504      3504           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray jaredwray merged commit df417aa into main Jul 5, 2026
12 checks passed
@jaredwray jaredwray deleted the claude/cacheable-dependency-management-d6gb1r branch July 5, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants