mono - chore: upgrade code quality dependencies#1669
Conversation
Upgrade the code-quality tooling group to their latest minimumReleaseAge-gated versions: - vitest, @vitest/coverage-v8, @vitest/spy 4.1.5 -> 4.1.9 - @biomejs/biome 2.4.14 -> 2.5.2 - @faker-js/faker 10.4.0 -> 10.5.0 (root devDep and @cacheable/benchmark dependency, kept in lockstep) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P1TBuMiXotBjpNHYcbwvqf
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request updates several development and project dependencies across the workspace, including upgrading @biomejs/biome to 2.5.2, @faker-js/faker to 10.5.0, and vitest (along with its related packages) to 4.1.9. The pnpm-lock.yaml file has been updated accordingly to reflect these changes and clean up unused transitive dependencies. There are no review comments, and I have no additional feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1669 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 3504 3504
Branches 795 808 +13
=========================================
Hits 3504 3504 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Maintenance (
chore) — upgrades the code-quality tooling group (test runner, linter/formatter, and fake-data generator) to their latestminimumReleaseAge-gated versions. No source or public-API changes. This is the first PR of a dependency-management pass (dev phase, one group per PR).Versions
vitest^4.1.5→^4.1.9@vitest/coverage-v8^4.1.5→^4.1.9@vitest/spy^4.1.5→^4.1.9@biomejs/biome^2.4.14→^2.5.2@faker-js/faker^10.4.0→^10.5.0(root devDep and@cacheable/benchmarkdependency, kept in lockstep so a single faker version is resolved)Verification
pnpm buildpassespnpm test— every package passes at 100% coverage except 3 tests that reproduce identically onmain(verified by re-running with the pre-upgrade lockfile) and are specific to this sandbox, not caused by this change:cacheable-request › return with url and port— issues a real request to externalmockhttp.org:8080, unreachable in this sandbox and so times out (the:80variant of the same test passes).file-entry-cache › should return a file descriptor with checksum and errorandnormalizeEntries() › should return all entries— bothchmod 0o000a file to force a read error, but the sandbox runs as root, which bypasses permission bits so no error is produced.All three pass on GitHub CI (non-root runner, full network).
Generated by Claude Code