Repository navigation
Support documented Proc width overwrites - #37
Open
OskarEichler wants to merge 2 commits into
Open
OskarEichler wants to merge 2 commits into
OskarEichler wants to merge 2 commits into
Conversation
Owner
|
Looks good, but can you add a few test cases? If overwrite is not passed, nil, false, or an |
Contributor
Author
|
Added the requested cases in cd0824a. Specs assert that custom processing is skipped for omitted/nil/false/empty overwrites, while non-empty hashes, Procs, and lookup objects apply the override. Full suite on Ruby 4.0.6: 69 examples, zero failures; git diff --check passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README documents Proc values for
overwrite:, but the current empty-check callsProc#empty?and raises. Accept non-collection lookup objects and retain the empty-Hash fast path. Cache each lookup as well, preventing stateful Proc values from being evaluated twice for one codepoint.Verified with the full 67-example suite and a focused Proc/lookup-count model on Ruby 4.0.6 and 3.2.11.