Skip to content

Allow disabling emoji handling per config call - #34

Merged
janlelis merged 1 commit into
janlelis:mainfrom
OskarEichler:codex/allow-false-emoji-override
Sep 5, 2026
Merged

janlelis merged 1 commit into
janlelis:mainfrom
OskarEichler:codex/allow-false-emoji-override

Conversation

@OskarEichler

Copy link
Copy Markdown
Contributor

A configured instance currently resolves per-call options with ||, so emoji: false cannot override a truthy instance default. Use fetch for the emoji key so an explicit false reaches the normal option normalization path.

Verified with the full 67-example suite and a focused configured-instance model on Ruby 4.0.6 and 3.2.11.

@janlelis
janlelis merged commit 7731a91 into janlelis:main Sep 5, 2026
25 checks passed
@janlelis

janlelis commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants