Repository navigation
Fix the in-app extra row slash, Return, Clip, and clipboard suite - #111
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2fb2331267
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
Migrate clipboard pins from the standard suite into the App Group, keep armed Ctrl across a paste, and pin slash/clip/SCP overlays above the keyboard layout guide.
|
@codex review |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c3f89830b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The extension owned the old store, so it must copy its standard suite into the App Group. A system Return now consumes armed Ctrl.
Closes #98
Closes #99
Closes #100
Closes #101
The SSH accessory extra row advertised slash commands, Clip, and SCP, and the system Return key looked like submit. None of that was true in the app:
/went throughANSISequence.bytes(.slash), which isnil. There was noSlashCommandPanelin the terminal. The extension already opened the panel.insertText("\n")wrote LF (0x0a). Agents and shells want CR (0x0d).UIPasteboard.generalonce. SCP was an emptyextraRowDidTapUpload.ClipboardHistoryusedUserDefaults.standard, so pins never crossed the app/extension boundary. Same class of bugKeyboardPrefsalready fixed.What changed
TerminalInputMappingis the shipped submit/newline/extra-row map. A lone Return is CR. A dedicated newline helper writes LF. Slash is.openSlash.TerminalInputViewuses that map. Extra-row/presentsSlashCommandPaneland writes the trigger (e.g./compact) to the PTY. Clip and SCP present the real panels. SCP sharesCitadelSCPUploaderwith the extension.ClipboardHistorydefaults togroup.com.keyjawn.Tests
TerminalInputView.insertTextandTerminalInputMapping./opens the panel; selecting/compactwrites those bytes.Review
Codex 5.4/low: password-auth hosts can still be picked in the SCP panel even though the uploader is Ed25519-only. That is also how the extension panel already works. Filed as #110 rather than changing both surfaces here.
Out of scope
No TestFlight/App Store upload. No version bump. Password-host filter is #110. Prompt scratchpad and path-back-into-prompt remain deferred (#103, #104).