FEATURE: Add zk start, stop, status, list, delete commands

cmd/zk/delete.go

@@ -1,12 +1,17 @@
 package zk
 
-import "github.com/spf13/cobra"
+import (
+	"github.com/jam2in/arcusctl/internal/zk"
+	"github.com/spf13/cobra"
+)
 
 var deleteCmd = &cobra.Command{
 	Use:   "delete <ensemble-name>",
 	Short: "Delete a ZooKeeper ensemble",
 	Args:  cobra.ExactArgs(1),
 	Run: func(cmd *cobra.Command, args []string) {
-		// TODO: delete 구현
+		if err := zk.Delete(args[0]); err != nil {
+			panic(err)
+		}
 	},
 }

cmd/zk/list.go

@@ -1,12 +1,17 @@
 package zk
 
-import "github.com/spf13/cobra"
+import (
+	"github.com/jam2in/arcusctl/internal/zk"
+	"github.com/spf13/cobra"
+)
 
 var listCmd = &cobra.Command{
 	Use:   "list",
 	Short: "List ZooKeeper ensembles",
 	Args:  cobra.NoArgs,
 	Run: func(cmd *cobra.Command, args []string) {
-		// TODO: list 구현
+		if err := zk.List(); err != nil {
+			panic(err)
+		}
 	},
 }

cmd/zk/start.go

@@ -1,13 +1,21 @@
 package zk
 
-import "github.com/spf13/cobra"
+import (
+	"github.com/jam2in/arcusctl/internal/zk"
+	"github.com/spf13/cobra"
+)
 
 var startCmd = &cobra.Command{
 	Use:   "start <ensemble-name> [--node <myid>]",
 	Short: "Start a ZooKeeper ensemble",
 	Args:  cobra.ExactArgs(1),
 	Run: func(cmd *cobra.Command, args []string) {
-		// TODO: start 구현
+		ensembleName := args[0]
+		myID, _ := cmd.Flags().GetInt("node")
+
+		if err := zk.Start(ensembleName, myID); err != nil {
+			panic(err)
+		}
 	},
 }
 

cmd/zk/status.go

@@ -1,12 +1,17 @@
 package zk
 
-import "github.com/spf13/cobra"
+import (
+	"github.com/jam2in/arcusctl/internal/zk"
+	"github.com/spf13/cobra"
+)
 
 var statusCmd = &cobra.Command{
 	Use:   "status <ensemble-name>",
 	Short: "Show status of a ZooKeeper ensemble",
 	Args:  cobra.ExactArgs(1),
 	Run: func(cmd *cobra.Command, args []string) {
-		// TODO: status 구현
+		if err := zk.Status(args[0]); err != nil {
+			panic(err)
+		}
 	},
 }

cmd/zk/stop.go

@@ -1,13 +1,21 @@
 package zk
 
-import "github.com/spf13/cobra"
+import (
+	"github.com/jam2in/arcusctl/internal/zk"
+	"github.com/spf13/cobra"
+)
 
 var stopCmd = &cobra.Command{
 	Use:   "stop <ensemble-name> [--node <myid>]",
 	Short: "Stop a ZooKeeper ensemble",
 	Args:  cobra.ExactArgs(1),
 	Run: func(cmd *cobra.Command, args []string) {
-		// TODO: stop 구현
+		ensembleName := args[0]
+		myID, _ := cmd.Flags().GetInt("node")
+
+		if err := zk.Stop(ensembleName, myID); err != nil {
+			panic(err)
+		}
 	},
 }
 

internal/store/store.go

@@ -6,6 +6,7 @@ import (
 	"time"
 
 	"github.com/jam2in/arcusctl/internal"
+	"github.com/jam2in/arcusctl/internal/topology"
 	"go.yaml.in/yaml/v3"
 )
 
@@ -63,11 +64,29 @@ func LoadZKMeta(ensembleName string) (*ZKMeta, error) {
 	return &meta, nil
 }
 
+func LoadZKTopology(ensembleName string) (*topology.ZKTopology, error) {
+	data, err := os.ReadFile(filepath.Join(zkDir(ensembleName), topologyYML))
+	if err != nil {
+		return nil, err
+	}
+
+	var topo topology.ZKTopology
+	if err := yaml.Unmarshal(data, &topo); err != nil {
+		return nil, err
+	}
+
+	return &topo, nil
+}
+
 func ZKExists(ensembleName string) bool {
 	_, err := os.Stat(filepath.Join(zkDir(ensembleName), metaYML))
 	return err == nil
 }
 
+func DeleteZK(ensembleName string) error {
+	return os.RemoveAll(zkDir(ensembleName))
+}
+
 func ListZK() ([]string, error) {
 	dir := zkBaseDir()
 	entries, err := os.ReadDir(dir)

internal/util.go

@@ -1,8 +1,10 @@
 package internal
 
 import (
+	"bufio"
 	"fmt"
 	"log"
+	"os"
 	"strings"
 	"syscall"
 	"time"
@@ -90,3 +92,16 @@ func ReadStdin(msg string, isPassword bool) string {
 		return input
 	}
 }
+
+// FIXME: ReadStdin와 통합 가능 여부 검토 필요
+func Confirm(prompt string) bool {
+	fmt.Print(prompt)
+	reader := bufio.NewReader(os.Stdin)
+	input, err := reader.ReadString('\n')
+	if err != nil {
+		return false
+	}
+
+	input = strings.TrimSpace(strings.ToLower(input))
+	return input == "y" || input == "yes"
+}

internal/zk/delete.go

@@ -0,0 +1,87 @@
+package zk
+
+import (
+	"fmt"
+	"strings"
+
+	"github.com/jam2in/arcusctl/internal"
+	"github.com/jam2in/arcusctl/internal/ssh"
+	"github.com/jam2in/arcusctl/internal/store"
+	"github.com/jam2in/arcusctl/internal/topology"
+)
+
+func Delete(ensembleName string) error {
+	_, topo, err := loadEnsemble(ensembleName)
+	if err != nil {
+		return err
+	}
+
+	if err := verifyTopology(topo); err != nil {
+		return err
+	}
+
+	if err := verifyAllStopped(topo); err != nil {
+		return err
+	}
+
+	fmt.Printf("This will remove ZooKeeper ensemble %q from all servers.\n", ensembleName)
+	if !internal.Confirm("Are you sure you want to proceed? (y/N): ") {
+		fmt.Println("Aborted.")
+		return nil
+	}
+
+	hostsMap := groupServersByHost(topo.Servers)
+	for host, servers := range hostsMap {
+		fmt.Printf("Removing files on %s...\n", host)
+		if err := removeHostFiles(host, servers, topo); err != nil {
+			return fmt.Errorf("remove files on %s: %w", host, err)
+		}
+	}
+
+	if err := store.DeleteZK(ensembleName); err != nil {
+		return fmt.Errorf("delete metadata: %w", err)
+	}
+
+	fmt.Printf("ZooKeeper ensemble %q deleted.\n", ensembleName)
+	return nil
+}
+
+func verifyTopology(topo *topology.ZKTopology) error {
+	for _, server := range topo.Servers {
+		confDir := fmt.Sprintf("%s/conf_myid_%d", topo.Path, server.MyID)
+		if err := ssh.Run(server.Host(), fmt.Sprintf("test -d %s", confDir)); err != nil {
+			return fmt.Errorf("topology mismatch: %s not found on %s", confDir, server.Host())
+		}
+	}
+	return nil
+}
+
+func verifyAllStopped(topo *topology.ZKTopology) error {
+	for _, server := range topo.Servers {
+		confPath := zkConfigPath(topo.Path, server.MyID)
+		cmd := fmt.Sprintf("pgrep -f 'QuorumPeerMain.*%s' > /dev/null 2>&1", confPath)
+		if err := ssh.Run(server.Host(), cmd); err == nil {
+			return fmt.Errorf("server %s (myid=%d) is still running. stop the ensemble before delete",
+				server.Host(), server.MyID)
+		}
+	}
+	return nil
+}
+
+func groupServersByHost(servers []topology.ZKServer) map[string][]topology.ZKServer {
+	hosts := map[string][]topology.ZKServer{}
+	for _, server := range servers {
+		hosts[server.Host()] = append(hosts[server.Host()], server)
+	}
+	return hosts
+}
+
+func removeHostFiles(host string, servers []topology.ZKServer, topo *topology.ZKTopology) error {
+	paths := []string{topo.Path}
+	for _, server := range servers {
+		paths = append(paths, fmt.Sprintf("%s/zk%d", server.Config.DataDir, server.MyID))
+	}
+
+	cmd := "rm -rf " + strings.Join(paths, " ")
+	return ssh.Run(host, cmd)
+}

internal/zk/deploy.go

@@ -1,12 +1,11 @@
 package zk
 
 import (
-	"bufio"
 	"fmt"
 	"os"
-	"strings"
 	"text/tabwriter"
 
+	"github.com/jam2in/arcusctl/internal"
 	"github.com/jam2in/arcusctl/internal/store"
 	"github.com/jam2in/arcusctl/internal/topology"
 )
@@ -18,7 +17,7 @@ func Deploy(version string, topologyPath string) error {
 	}
 
 	printPlan(topo, version)
-	if !confirm() {
+	if !internal.Confirm("Proceed with deployment? (y/N): ") {
 		fmt.Println("Aborted.")
 		return nil
 	}
@@ -49,10 +48,7 @@ func prepareTopology(topologyPath string) (*topology.ZKTopology, []byte, error)
 		return nil, nil, err
 	}
 
-	for i := range topo.Servers {
-		merged := mergeConfig(topo.GlobalConfig, topo.Servers[i].Config)
-		topo.Servers[i].Config = &merged
-	}
+	mergeServerConfigs(topo)
 
 	if err := topo.Validate(); err != nil {
 		return nil, nil, err
@@ -97,16 +93,3 @@ func printRecoveryGuide(deployed []topology.ZKServer, topo *topology.ZKTopology)
 	fmt.Println("\nTo clean up, manually run on each server:")
 	fmt.Printf("  rm -rf %s/conf_myid_<myid>\n", topo.Path)
 }
-
-func confirm() bool {
-	// FIXME: internal.ReadStdin()으로 변경 필요
-	fmt.Print("\nProceed? [y/N]: ")
-	reader := bufio.NewReader(os.Stdin)
-	input, err := reader.ReadString('\n')
-	if err != nil {
-		return false
-	}
-
-	input = strings.TrimSpace(strings.ToLower(input))
-	return input == "y" || input == "yes"
-}

internal/zk/ensemble.go

@@ -0,0 +1,39 @@
+package zk
+
+import (
+	"fmt"
+
+	"github.com/jam2in/arcusctl/internal/store"
+	"github.com/jam2in/arcusctl/internal/topology"
+)
+
+func loadEnsemble(name string) (*store.ZKMeta, *topology.ZKTopology, error) {
+	meta, err := store.LoadZKMeta(name)
+	if err != nil {
+		return nil, nil, fmt.Errorf("load ZooKeeper metadata %q: %w", name, err)
+	}
+
+	topo, err := store.LoadZKTopology(name)
+	if err != nil {
+		return nil, nil, fmt.Errorf("load ZooKeeper topology %q: %w", name, err)
+	}
+
+	if topo.Name != name {
+		return nil, nil, fmt.Errorf("ZooKeeper topology name mismatch: got %q, want %q", topo.Name, name)
+	}
+
+	mergeServerConfigs(topo)
+
+	if err := topo.Validate(); err != nil {
+		return nil, nil, fmt.Errorf("invalid ZooKeeper topology %q: %w", name, err)
+	}
+
+	return meta, topo, nil
+}
+
+func mergeServerConfigs(topo *topology.ZKTopology) {
+	for i := range topo.Servers {
+		merged := mergeConfig(topo.GlobalConfig, topo.Servers[i].Config)
+		topo.Servers[i].Config = &merged
+	}
+}

internal/zk/list.go

@@ -0,0 +1,33 @@
+package zk
+
+import (
+	"fmt"
+	"os"
+	"text/tabwriter"
+
+	"github.com/jam2in/arcusctl/internal/store"
+)
+
+func List() error {
+	names, err := store.ListZK()
+	if err != nil {
+		return fmt.Errorf("list ZooKeeper ensembles: %w", err)
+	}
+
+	if len(names) == 0 {
+		fmt.Println("No ZooKeeper ensemble found.")
+		return nil
+	}
+
+	w := tabwriter.NewWriter(os.Stdout, 0, 0, 2, ' ', 0)
+	fmt.Fprintln(w, "NAME\tVERSION\tDEPLOYED AT")
+	for _, name := range names {
+		meta, err := store.LoadZKMeta(name)
+		if err != nil {
+			fmt.Fprintf(w, "%s\t<error>\t%v\n", name, err)
+			continue
+		}
+		fmt.Fprintf(w, "%s\t%s\t%s\n", meta.Name, meta.Version, meta.DeployedAt.Format("2006-01-02 15:04:05"))
+	}
+	return w.Flush()
+}