fix(twitter): fail typed when a write command does not go through

[Benjamin-eecs]

Problem

Closes #2255. Fifteen single-target Twitter write commands returned a status: failed row when a write did not happen, so the process still exited 0 and agents could not distinguish success from failure.

A second safety boundary matters once these become errors: after a write click, failure to observe the expected UI state does not prove the server rejected the write. Treating that as a definite CommandExecutionError invites an automatic retry and duplicate likes, follows, blocks, retweets, or posts.

Fix

The adapter now preserves the write phase:

• Before the final write click — missing controls, menus, confirmation items, unusable composers, or X failure toasts — throw CommandExecutionError because nothing changed.
• After the final write click — confirmation polling expires, the UI does not switch state, or an exception occurs — return unconfirmed from the page script and throw TimeoutError (exit 75) with a “check before retrying” hint.
• Already-correct/idempotent states remain success.
• Batch commands keep per-item partial-result rows.

This applies to post/reply/quote; like/unlike/bookmark/unbookmark; follow/unfollow/block/unblock; retweet/unretweet. Delete and hide-reply keep definite errors for their pre-write failure branches.

Regression coverage

In addition to command-level typed-error tests, three real JSDOM script executions pin the phase boundary across different UI families:

• direct toggle: Like click with no observed Unlike state → TimeoutError
• two-step menu: Retweet confirm click with no observed Unretweet state → TimeoutError
• profile confirmation: missing Block confirmation dialog → CommandExecutionError; confirm click with no observed blocked state → TimeoutError

The DOM helper executes the exact injected browser script with waits collapsed, rather than mocking its returned phase metadata.

Verification

Exact head 74088913:

• Twitter suite: 43 files / 509 tests passed
• npm run typecheck passed
• npm run build passed; manifest 1331 entries
• typed-error lint: no new violations
• silent-column-drop gate: no new violations
• git diff --check passed

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.