[jackielii]

Problem

TestRegion_Integration and TestKeyed_Integration in tools/lint were missing every .templ finding: 8 for region and 4 for keyed. The .templ half of both checks was effectively untested, and CI never runs the tools/lint tests, so it went unnoticed.

Root cause

The linter maps a .templ attribute to its generated code through templ's source map only when the _templ.go is byte-for-byte what the templ generator produces. That check was correct: templ generate v0.3.1020 is generator.Generate followed by format.Source, which is exactly what the linter reproduces.

The fixtures were the problem. .githooks/pre-commit runs goimports -w and gofmt -w -s over every tracked .go file except gsx's *.x.go, then re-stages them. goimports regrouped each committed *_templ.go's three import lines into one block, so every fixture read as stale and its attributes were skipped. #44's new fixture passed before its commit and broke when the hook rewrote it.

Fix

• Hook: .githooks/pre-commit skips *_templ.go as it already skips *.x.go.

• Fixtures: all five templ fixtures are regenerated with templ v0.3.1020, each from the directory it was originally generated in, so FileName doesn't change. Their deliberate differences are kept:

  • pages_templ.go has another version header;
  • noversion_templ.go has none;
  • stale_templ.go has an edited comment that keeps it stale.

  Each file's diff is the import block only.

• Guard: a new test, templscan.TestExprAttrs_fixturesAreTemplOutput, checks that every fixture is accepted except stale.templ. Its failure message says how to regenerate a fixture.

• CI: a new Test tools/lint job runs go test ./... in tools/lint on Go 1.26.

• Docs: docs/lint.md now names a formatter run over a _templ.go (goimports regroups its imports) as one of the differences that leave its attributes unchecked, and advises leaving *_templ.go out of goimports/gofmt -s.

Impact on users

None in the linter: templ generate output was always checked. Only a project that reformats its _templ.go after generating gets its templ attributes skipped, and the docs now say so.

Testing

• cd tools/lint && go test -count=1 ./... passes, TestRegion_Integration and TestKeyed_Integration included, for the first time in a while.
• Root suite and golangci-lint pass.
• After committing through the updated hook, the fixtures are unchanged in the commit.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.09%. Comparing base (453fcdc) to head (7594c51).

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files          20       20           
  Lines        1869     1869           
=======================================
  Hits         1796     1796           
  Misses         43       43           
  Partials       30       30           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.