Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/build-installers/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ inputs:
runs:
using: "composite"
steps:
- name: Set up JDK 21 # NBPackage requires JDK
- name: Set up JDK 25 # NBPackage requires JDK
uses: actions/setup-java@v5
with:
java-version: '21'
java-version: '25'
Comment on lines +18 to +21

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The actions/setup-java action with the temurin distribution will fail to resolve Java version 25 because it has not been released yet. This will break the GitHub Actions workflow.

    - name: Set up JDK 21 # NBPackage requires JDK
      uses: actions/setup-java@v5
      with:
        java-version: '21'

distribution: 'temurin'

- name: Download bundle
Expand Down
4 changes: 2 additions & 2 deletions .github/actions/build-sdk/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ inputs:
runs:
using: "composite"
steps:
- name: Set up JDK 21
- name: Set up JDK 25
uses: actions/setup-java@v5
with:
java-version: '21'
java-version: '25'
Comment on lines +17 to +20

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The actions/setup-java action with the temurin distribution will fail to resolve Java version 25 because it has not been released yet. This will break the GitHub Actions workflow.

    - name: Set up JDK 21
      uses: actions/setup-java@v5
      with:
        java-version: '21'

Comment on lines +17 to +20
distribution: 'temurin'

- name: Validate the Gradle wrapper
Expand Down
4 changes: 2 additions & 2 deletions BasicGameTemplate/nbproject/project.properties
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ javac.compilerargs=
javac.deprecation=false
javac.processorpath=\
${javac.classpath}
javac.source=21
javac.target=21
javac.source=25
javac.target=25
javac.test.classpath=\
${javac.classpath}:\
${build.classes.dir}
Expand Down
4 changes: 2 additions & 2 deletions JME3TestsTemplate/nbproject/project.properties
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ javac.classpath=\
# Space-separated list of extra javac options
javac.compilerargs=
javac.deprecation=false
javac.source=21
javac.target=21
javac.source=25
javac.target=25
javac.test.classpath=\
${javac.classpath}:\
${build.classes.dir}
Expand Down
2 changes: 1 addition & 1 deletion installers/download-jdks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

set -e # Quit on Error

jdk_major_version="21"
jdk_major_version="25"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

JDK 25 is not yet released as a General Availability (GA) version. The Adoptium API endpoint used on line 25 (/v3/binary/latest/$jdk_major_version/ga/...) will return a 404 error because no GA release exists for JDK 25. Since set -e is enabled, this will cause the script to fail immediately during the build process.

Suggested change
jdk_major_version="25"
jdk_major_version="21"

jvm_impl="hotspot"
jdk_vendor="eclipse"

Expand Down
2 changes: 1 addition & 1 deletion jme3-android/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Updated by build script
#Thu, 25 Aug 2011 21:00:54 +0200
javac.source=21
javac.source=25

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Android development tools and the Android Gradle Plugin do not support Java 25. Setting javac.source to 25 for the Android module will cause compilation and compatibility issues, as Android currently supports up to Java 17/21 depending on the AGP version.

javac.source=21

javac.compilerargs=-Xlint -Xlint:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
2 changes: 1 addition & 1 deletion jme3-angelfont/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#Thu, 25 Aug 2011 20:26:50 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint\:-serial
nbm.homepage=https://www.jmonkeyengine.org
nbm.module.author=Normen Hansen
Expand Down
2 changes: 1 addition & 1 deletion jme3-assetbrowser/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#Thu, 25 Aug 2011 20:26:49 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
2 changes: 1 addition & 1 deletion jme3-assetpack-support/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#Thu, 25 Aug 2011 20:26:49 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint\:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
4 changes: 2 additions & 2 deletions jme3-autodesk/nbproject/platform.properties
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,8 @@ nbplatform.active=default
#need these in the file for all dependencies to resolve when using command line
#ant and a download of the platform, same as those generated by netbeans platform
#under ${user.properties.file} (defined in platform-private.properties)
default.javac.source=21
default.javac.target=21
default.javac.source=25
default.javac.target=25
libs.absolutelayout.classpath=${nbplatform.default.netbeans.dest.dir}/java/modules/ext/AbsoluteLayout.jar
libs.absolutelayout.javadoc=
libs.absolutelayout.maven-pom=
Expand Down
2 changes: 1 addition & 1 deletion jme3-autodesk/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
auxiliary.org-netbeans-spi-editor-hints-projects.perProjectHintSettingsFile=nbproject/cfg_hints.xml
#Thu, 25 Aug 2011 20:26:49 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint\:-serial
spec.version.base=3.6.1
2 changes: 1 addition & 1 deletion jme3-cinematics/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#Thu, 25 Aug 2011 20:26:50 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint\:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
2 changes: 1 addition & 1 deletion jme3-code-check/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#Thu, 25 Aug 2011 20:26:50 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
2 changes: 1 addition & 1 deletion jme3-codepalette/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#Thu, 25 Aug 2011 20:26:49 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint\:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
2 changes: 1 addition & 1 deletion jme3-core-baselibs/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint\:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
2 changes: 1 addition & 1 deletion jme3-core-libraries/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#Thu, 25 Aug 2011 20:26:48 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint\:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
2 changes: 1 addition & 1 deletion jme3-core-updatecenters/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#Thu, 25 Aug 2011 20:26:49 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint\:-serial
spec.version.base=3.5.2
2 changes: 1 addition & 1 deletion jme3-core/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#Thu, 25 Aug 2011 20:26:48 +0200
file.reference.DDSUtils.jar=release/modules/ext/DDSUtils.jar
#Thu, 25 Aug 2011 19:32:54 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint\:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
2 changes: 1 addition & 1 deletion jme3-dark-laf/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
file.reference.nimrodlf.jar=release/modules/ext/nimrodlf.jar
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
2 changes: 1 addition & 1 deletion jme3-desktop-executables/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#Thu, 25 Aug 2011 20:26:49 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint\:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
2 changes: 1 addition & 1 deletion jme3-documentation/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
2 changes: 1 addition & 1 deletion jme3-glsl-highlighter/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint:-serial
project.license=jme license
2 changes: 1 addition & 1 deletion jme3-gui/nbproject/project.properties
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ file.reference.slf4j-simple-1.7.7.jar=release/modules/ext/slf4j-simple-1.7.7.jar
file.reference.swingtonifty.jar=release/modules/ext/swingtonifty.jar
file.reference.xsom-20110101-SNAPSHOT.jar=release/modules/ext/xsom-20110101-SNAPSHOT.jar
#Thu, 25 Aug 2011 20:26:49 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
2 changes: 1 addition & 1 deletion jme3-lwjgl-applet/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#Thu, 25 Aug 2011 20:26:49 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint\:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
2 changes: 1 addition & 1 deletion jme3-materialeditor/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#Thu, 25 Aug 2011 20:26:49 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint\:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
2 changes: 1 addition & 1 deletion jme3-model-importer/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#Thu, 25 Aug 2011 20:26:49 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint\:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
2 changes: 1 addition & 1 deletion jme3-navmesh-gen/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
2 changes: 1 addition & 1 deletion jme3-obfuscate/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#Thu, 25 Aug 2011 20:26:50 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint\:-serial
license.file=../license-jme.txt
nbm.homepage=https\://proguard.sourceforge.net/
Expand Down
2 changes: 1 addition & 1 deletion jme3-project-baselibs/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#Thu, 25 Aug 2011 20:26:48 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint\:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
2 changes: 1 addition & 1 deletion jme3-project-libraries/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#Thu, 25 Aug 2011 20:26:48 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint\:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
2 changes: 1 addition & 1 deletion jme3-project-testdata/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#Thu, 25 Aug 2011 20:26:48 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint\:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
2 changes: 1 addition & 1 deletion jme3-scenecomposer/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#Thu, 25 Aug 2011 20:26:49 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint\:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
2 changes: 1 addition & 1 deletion jme3-templates/nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#Thu, 25 Aug 2011 20:26:48 +0200
javac.source=21
javac.source=25
javac.compilerargs=-Xlint -Xlint\:-serial
license.file=../license-jme.txt
nbm.homepage=https://www.jmonkeyengine.org
Expand Down
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ project(":assets") {

java {
toolchain {
languageVersion = JavaLanguageVersion.of(21)
languageVersion = JavaLanguageVersion.of(25)
}
}
}
Expand Down Expand Up @@ -114,7 +114,7 @@ jar {

java {
toolchain {
languageVersion = JavaLanguageVersion.of(21)
languageVersion = JavaLanguageVersion.of(25)
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public JaimesAscentDownloadPanel() {
}

public int doDownloadZip() {
return downloadFile("https://github.com/neph1/JaimesAscent/archive/refs/tags/v1.1.1.zip", DOWNLOAD_FOLDER, ZIP_NAME);
return downloadFile("https://github.com/neph1/JaimesAscent/archive/refs/tags/v1.1.3.zip", DOWNLOAD_FOLDER, ZIP_NAME);
}

private int downloadFile(String fileURL, String saveDir, String fileName) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,20 @@ plugins {
id 'application'
}

group 'com.JaimesAscent'
version '1.0'
group = 'com.JaimesAscent'
version = '1.0'

mainClassName = "com.JaimesAscent.JaimesAscent"
application {
applicationName = '${name}'
mainClass = 'com.JaimesAscent.JaimesAscent'
}

repositories {
mavenCentral()
}

project.ext {
jmeVer = '3.7.0-stable'
jmeVer = '3.9.0-stable'
}

project(":assets") {
Expand All @@ -31,14 +34,14 @@ project(":assets") {

java {
toolchain {
languageVersion = JavaLanguageVersion.of(21)
languageVersion = JavaLanguageVersion.of(25)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Gradle 8.6 (configured in the wrapper at line 64) does not support Java 25. Gradle 8.6 only supports up to Java 21 officially. Attempting to use a Java 25 toolchain with this Gradle version will result in a configuration or build failure.

Suggested change
languageVersion = JavaLanguageVersion.of(25)
languageVersion = JavaLanguageVersion.of(21)

}
}
}

java {
toolchain {
languageVersion = JavaLanguageVersion.of(21)
languageVersion = JavaLanguageVersion.of(25)
}
}

Expand All @@ -48,18 +51,18 @@ dependencies {
implementation "org.jmonkeyengine:jme3-desktop:$jmeVer"
implementation "org.jmonkeyengine:jme3-lwjgl:$jmeVer"
implementation "org.jmonkeyengine:jme3-lwjgl:$jmeVer"
implementation "com.github.stephengold:Heart:9.0.0"
implementation "com.github.stephengold:Minie:8.0.0"
implementation "com.github.stephengold:Heart:9.3.0"
implementation "com.github.stephengold:Minie:9.0.3"
implementation project("assets")

}

jar {
manifest {
attributes 'Main-Class': "$mainClassName"
attributes 'Main-Class': application.mainClass
}
}

wrapper {
gradleVersion = '8.6'
gradleVersion = '9.2.1'
}
Loading