-
Notifications
You must be signed in to change notification settings - Fork 104
Java 25 #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 25 #706
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,10 +14,10 @@ inputs: | |
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Set up JDK 21 | ||
| - name: Set up JDK 25 | ||
| uses: actions/setup-java@v5 | ||
| with: | ||
| java-version: '21' | ||
| java-version: '25' | ||
|
Comment on lines
+17
to
+20
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Comment on lines
+17
to
+20
|
||
| distribution: 'temurin' | ||
|
|
||
| - name: Validate the Gradle wrapper | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |||||
|
|
||||||
| set -e # Quit on Error | ||||||
|
|
||||||
| jdk_major_version="21" | ||||||
| jdk_major_version="25" | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. JDK 25 is not yet released as a General Availability (GA) version. The Adoptium API endpoint used on line 25 (
Suggested change
|
||||||
| jvm_impl="hotspot" | ||||||
| jdk_vendor="eclipse" | ||||||
|
|
||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| #Updated by build script | ||
| #Thu, 25 Aug 2011 21:00:54 +0200 | ||
| javac.source=21 | ||
| javac.source=25 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| javac.compilerargs=-Xlint -Xlint:-serial | ||
| license.file=../license-jme.txt | ||
| nbm.homepage=https://www.jmonkeyengine.org | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| auxiliary.org-netbeans-spi-editor-hints-projects.perProjectHintSettingsFile=nbproject/cfg_hints.xml | ||
| #Thu, 25 Aug 2011 20:26:49 +0200 | ||
| javac.source=21 | ||
| javac.source=25 | ||
| javac.compilerargs=-Xlint -Xlint\:-serial | ||
| spec.version.base=3.6.1 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| #Thu, 25 Aug 2011 20:26:49 +0200 | ||
| javac.source=21 | ||
| javac.source=25 | ||
| javac.compilerargs=-Xlint -Xlint\:-serial | ||
| spec.version.base=3.5.2 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| javac.source=21 | ||
| javac.source=25 | ||
| javac.compilerargs=-Xlint -Xlint:-serial | ||
| project.license=jme license |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -3,17 +3,20 @@ plugins { | |||||
| id 'application' | ||||||
| } | ||||||
|
|
||||||
| group 'com.JaimesAscent' | ||||||
| version '1.0' | ||||||
| group = 'com.JaimesAscent' | ||||||
| version = '1.0' | ||||||
|
|
||||||
| mainClassName = "com.JaimesAscent.JaimesAscent" | ||||||
| application { | ||||||
| applicationName = '${name}' | ||||||
| mainClass = 'com.JaimesAscent.JaimesAscent' | ||||||
| } | ||||||
|
|
||||||
| repositories { | ||||||
| mavenCentral() | ||||||
| } | ||||||
|
|
||||||
| project.ext { | ||||||
| jmeVer = '3.7.0-stable' | ||||||
| jmeVer = '3.9.0-stable' | ||||||
| } | ||||||
|
|
||||||
| project(":assets") { | ||||||
|
|
@@ -31,14 +34,14 @@ project(":assets") { | |||||
|
|
||||||
| java { | ||||||
| toolchain { | ||||||
| languageVersion = JavaLanguageVersion.of(21) | ||||||
| languageVersion = JavaLanguageVersion.of(25) | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Gradle 8.6 (configured in the wrapper at line 64) does not support Java 25. Gradle 8.6 only supports up to Java 21 officially. Attempting to use a Java 25 toolchain with this Gradle version will result in a configuration or build failure.
Suggested change
|
||||||
| } | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| java { | ||||||
| toolchain { | ||||||
| languageVersion = JavaLanguageVersion.of(21) | ||||||
| languageVersion = JavaLanguageVersion.of(25) | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
|
|
@@ -48,18 +51,18 @@ dependencies { | |||||
| implementation "org.jmonkeyengine:jme3-desktop:$jmeVer" | ||||||
| implementation "org.jmonkeyengine:jme3-lwjgl:$jmeVer" | ||||||
| implementation "org.jmonkeyengine:jme3-lwjgl:$jmeVer" | ||||||
| implementation "com.github.stephengold:Heart:9.0.0" | ||||||
| implementation "com.github.stephengold:Minie:8.0.0" | ||||||
| implementation "com.github.stephengold:Heart:9.3.0" | ||||||
| implementation "com.github.stephengold:Minie:9.0.3" | ||||||
| implementation project("assets") | ||||||
|
|
||||||
| } | ||||||
|
|
||||||
| jar { | ||||||
| manifest { | ||||||
| attributes 'Main-Class': "$mainClassName" | ||||||
| attributes 'Main-Class': application.mainClass | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| wrapper { | ||||||
| gradleVersion = '8.6' | ||||||
| gradleVersion = '9.2.1' | ||||||
| } | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
actions/setup-javaaction with thetemurindistribution will fail to resolve Java version25because it has not been released yet. This will break the GitHub Actions workflow.