Skip to content

Update to Netbeans 30#704

Merged
tonihele merged 1 commit into
jMonkeyEngine:masterfrom
tonihele:feature/netbeans_30
Jun 9, 2026
Merged

Update to Netbeans 30#704
tonihele merged 1 commit into
jMonkeyEngine:masterfrom
tonihele:feature/netbeans_30

Conversation

@tonihele

@tonihele tonihele commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 9, 2026 16:59

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the NetBeans download URL to version 30 in gradle.properties and updates the executable hashes for app.exe and app64.exe in harness-override/override.properties. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@tonihele

tonihele commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

I'll merge soon, I don't think anyone will oppose?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the SDK’s NetBeans platform baseline to a newer Apache NetBeans distribution and aligns the harness launcher patching checksums so the build can continue to safely apply the Windows icon/launcher overrides.

Changes:

  • Bump the NetBeans base download URL from the Apache archive to NetBeans 30.
  • Update SHA-256 hashBefore/hashAfter entries for harness launcher executables used by the overrideHarness Gradle task.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
harness-override/override.properties Updates harness launcher SHA-256 hashes used to validate/guard the executable override step.
gradle.properties Points netbeansUrl at the NetBeans 30 binary zip in the Apache archive.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tonihele tonihele merged commit dad81ea into jMonkeyEngine:master Jun 9, 2026
2 checks passed
@tonihele tonihele deleted the feature/netbeans_30 branch June 9, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants