Repository navigation
Fix signing key lookup for Maven publications - #4
Merged
riccardobl merged 1 commit intoOct 31, 2026
Merged
Conversation
Check the project signingKey property in the signing predicate so CI does not skip signature generation when the key is supplied through Gradle's project-property environment variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2026-10-31 release run uploaded its artifacts but failed to close the Sonatype staging repository because all five signatures were missing.
signMavenPublicationwas skipped even though the signing credentials were available.Qualify the signing predicate with
project.hasProperty('signingKey')so it checks the Gradle project property supplied throughORG_GRADLE_PROJECT_signingKey. This enables signing when the key is provided and preserves the existing skip behavior when it is absent.Validation
An isolated reproduction using the module's build script, Gradle 9.8.0 and a temporary PGP key produced:
The patch changes only this predicate. No real credentials or Sonatype uploads were used for the local verification.
After merging, start a new release workflow dispatch from the corrected
master. Rerunning the failed workflow would retain its original commit and the old signing predicate.