Repository navigation
Fix performance and DX review findings - #3
Merged
Merged
Conversation
ryu-man
force-pushed
the
fix/codex-review
branch
from
October 16, 2026 22:15
585b776 to
7797d7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes all 20 findings from the performance and DX review of
@ixirjs/pulse. There is one commit per fix, and each fix has a focused test that I confirmed fails without it.Behavior changes (minor changeset)
spring()/springEasing()): sampled springs now take velocity in progress per second, the same unit the live spring uses. Before, the value was divided by 1000, so callers who compensated for that will need to scale their values down by 1000.call()/set(): these entries now run on the timeline's own clock instead ofsetTimeout. Pause, seek,playbackRateandfinishednow apply to them, and they don't fire while the timeline plays in reverse.animate: a prop with no target value (for examplex: [100]or{}) now throws aTypeErrorthat names the prop.prefers-reduced-motion. Both take arespectReducedMotionoption.Fixes (patch)
prepacknow smoke-tests the built package with a Node import.fill: 'none'and fractional iterations finish in the right state.cubic-bezier()easing strings are now honored.wheelablereleases its layer hint on cleanup.inViewchecksintersectionRatio, not just whether the element overlaps the viewport.scroll()measures progress from the element's resting position, ignoring the transform it is driving.^5.29.0, the first version with{@attach}. The README's transform shorthand table is corrected.Performance
Notes
bun run verifypasses, covering check, lint, 666 tests and size-limit.