Repository navigation
Conversation
Converted `signature` in `services/receiver/src/rd_poll.rs` to an `async fn` using `tokio::fs::metadata().await` instead of blocking `std::fs::metadata()`. This prevents filesystem I/O in background polling loops from blocking Tokio worker threads. Co-authored-by: iwismer <10574297+iwismer@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
⚡ What:
Converted
signatureinservices/receiver/src/rd_poll.rsfrom synchronousstd::fs::metadatato asynctokio::fs::metadata().awaitand updatedpoll_onceto awaitsignature(dir).🎯 Why:
The background poller (
rd_poll::run) executed synchronous filesystem metadata queries (std::fs::metadata) on the Tokio reactor execution threads during change detection. If the working directory was located on a network share, unmounted disk, or slow filesystem, these blocking calls could stall Tokio worker threads and cause reactor latency spikes for all other tasks on that worker thread.📊 Measured Improvement:
poll_onceandsignatureexecute asynchronously without blocking Tokio reactor threads.tests/bench_rd_poll.rs) and confirmed 100% test suite passing with zero regressions in change detection, keep-last-good failure recovery, and polling outcome logic.PR created automatically by Jules for task 11936214237658367043 started by @iwismer