Repository navigation
Conversation
Optimize loop inserts in `replace_bib_chips`, `replace_participants`, `replace_divisions`, and `replace_rd_data` by chunking rows into multi-row `VALUES` prepared SQL statements (chunk size 50). This significantly reduces SQLite query execution overhead during data imports. Co-authored-by: iwismer <10574297+iwismer@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Optimize loop inserts in `replace_bib_chips`, `replace_participants`, `replace_divisions`, and `replace_rd_data` by chunking rows into multi-row `VALUES` prepared SQL statements (chunk size 50). This significantly reduces SQLite query execution overhead during data imports. Also format code using `cargo fmt`. Co-authored-by: iwismer <10574297+iwismer@users.noreply.github.com>
💡 What:
Optimized
replace_bib_chips,replace_participants,replace_divisions, andreplace_rd_datainservices/receiver/src/db.rsby replacing single-row loop inserts with batch chunkedINSERT OR REPLACE INTO ... VALUESstatements (using a batch chunk size of 50).🎯 Why:
Previously, importing participant/chip mapping data performed one
stmt.execute(...)query per row in a loop. With large datasets (e.g. 10,000+ items), this loop query dispatch overhead created an N+1 query pattern.📊 Measured Improvement:
Measured using
benchmark_bulk_operationsin release mode for 10,000 items each:replace_bib_chips: 15.59 ms → 8.77 ms (~43.7% faster)replace_divisions: 6.12 ms → 4.01 ms (~34.5% faster)replace_participants: 9.10 ms → 8.32 ms (~8.6% faster)replace_rd_data: 30.80 ms → 22.33 ms (~27.5% faster)PR created automatically by Jules for task 6983175102808330700 started by @iwismer