Skip to content

⚡ Optimize subscription assignment loop in receiver db - #252

Merged
iwismer merged 1 commit into
mainfrom
perf/optimize-subs-assignment-12974985993301861592
Oct 14, 2026
Merged

iwismer merged 1 commit into
mainfrom
perf/optimize-subs-assignment-12974985993301861592

Conversation

@iwismer

@iwismer iwismer commented Oct 6, 2026

Copy link
Copy Markdown
Owner

💡 What:
Optimized replace_stream_subscriptions in services/receiver/src/db.rs by utilizing prepare_cached and direct low-level parameter binding (stmt.raw_bind_parameter(...) and stmt.raw_execute()) instead of allocating dynamic parameter slices (rusqlite::params![]) on every iteration of the subscription insertion loop.

🎯 Why:
When inserting multiple subscriptions, creating dynamic parameter vectors/slices (params![...]) on every row execution caused redundant parameter allocation and dynamic dispatch overhead. Switching to raw parameter binding and cached statements removes loop allocations while preserving exact functionality and parameter safety.

📊 Measured Improvement:

  • Benchmark: bench_replace_stream_subscriptions (1,000 subscriptions, 20 iterations)
  • Debug build: Reduced average runtime per batch from ~8.85 ms to ~6.07 ms (~31% speedup / 1.46x faster).
  • Release build: Reduced average runtime per batch from ~1.89 ms to ~1.72 ms (~9% speedup / 1.10x faster).

PR created automatically by Jules for task 12974985993301861592 started by @iwismer

Co-authored-by: iwismer <10574297+iwismer@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@iwismer
iwismer merged commit 1d74631 into main Oct 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant