Skip to content

⚡ Batch insert bib chips in streamer to eliminate N+1 query overhead - #249

Merged
iwismer merged 1 commit into
mainfrom
perf/batch-import-bib-chips-2990190191013890227
Oct 14, 2026
Merged

iwismer merged 1 commit into
mainfrom
perf/batch-import-bib-chips-2990190191013890227

Conversation

@iwismer

@iwismer iwismer commented Oct 6, 2026

Copy link
Copy Markdown
Owner

💡 What:
Optimized import_bib_chips in services/streamer/src/lib.rs by batching chip insertions into 50-row multi-value SQL INSERT OR IGNORE statements. Also added an early return check for empty input slices.

🎯 Why:
Previously, import_bib_chips executed single-row SQL INSERT statements inside a loop for each chip record (an N+1 query pattern). Batching insertions into chunked queries significantly reduces SQLite statement execution overhead.

📊 Measured Improvement:
In benchmark testing on 10,000 items in release mode (bench_import_bib_chips):

  • Baseline: ~12.7ms – 22.8ms (average ~16ms)
  • Optimized: ~8.6ms – 8.8ms
  • Improvement: ~30% – 45% reduction in execution time (~1.5x - 2x speedup).

PR created automatically by Jules for task 2990190191013890227 started by @iwismer

Co-authored-by: iwismer <10574297+iwismer@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@iwismer
iwismer merged commit 62446b8 into main Oct 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant