Skip to content

perf(proxy): optimize subdomain checking with incremental string building #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lamtrinhdev wants to merge 4 commits into
base: develop
Choose a base branch
from
+10 −3
Open

perf(proxy): optimize subdomain checking with incremental string building #113

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76299bd
perf(proxy): optimize subdomain checking by building candidates incre…
lamtrinhdev Apr 30, 2026
c857333
Merge pull request #146 from ivpn/release/0.1.11
MaciejTe May 14, 2026
d9258e5
Enhance after Copilot feedback.
lamtrinhdev May 29, 2026
302504b
Merge branch 'ivpn:main' into main
lamtrinhdev May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions proxy/filter/blocklists.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,17 @@ func (f *DomainFilter) filterBlocklists(reqCtx *requestcontext.RequestContext, d
}

if reqCtx.PrivacySettings[SUBDOMAINS_RULE] == RULE_BLOCK {
// iterate over all subdomains
// iterate over all subdomains (excluding TLD and full FQDN)
parts := strings.Split(fqdn, ".")
for i := range len(parts) - 1 {
candidate := strings.Join(parts[i:], ".")
var candidate string
for i := len(parts) - 2; i >= 0; i-- {
// Build candidate incrementally by prepending current part
if i == len(parts)-2 {
candidate = parts[i] + "." + parts[i+1]
} else {
candidate = parts[i] + "." + candidate
}

// now, check if candidate domain is part of any blocklist entry
blocklisted, err = f.Cache.GetBlocklistEntry(context.Background(), blocklistId, candidate)
if err != nil {
Expand Down