fix: snapshot backgroundFetchSize before invoking user code - #410
Open
teamleaderleo wants to merge 1 commit into
Open
fix: snapshot backgroundFetchSize before invoking user code#410teamleaderleo wants to merge 1 commit into
teamleaderleo wants to merge 1 commit into
Conversation
Validate backgroundFetchSize and snapshot it before synchronous fetchMethod code can mutate the public field. Keep regression coverage focused on supported public behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backgroundFetchSizeis used to account for a background fetch while its value is still pending.Unlike normal cache sizes, it currently bypasses the usual size validation. Invalid values such as negative numbers, fractions,
NaN, orInfinitycan therefore reach the cache's size accounting.There's also a timing issue when
fetchMethodchangesbackgroundFetchSizesynchronously. The current fetch can end up using the new value even though it started with the old one.This change validates
backgroundFetchSizeand snapshots it before callingfetchMethod, so each in-flight fetch keeps the size it started with.0remains valid, and changes tobackgroundFetchSizestill apply to later fetches.Tests
Added coverage for:
backgroundFetchSizevalues;fetchMethod;backgroundFetchSize: 0;