Environment view and profile status bar (ADR 0009 phase 5) - #92
Merged
Conversation
Phase 5 of ADR 0009, two parts of three; the third is corrected and deferred, not merely postponed. The environment inspector is a tree view over a custom ironkernel/environment request: the capability set, the buffer's defines as the innermost frame, then every reachable frame with each binding classified and its contract as detail. Frame structure stays host-side exactly as phase 2 decided -- the view knows the parents, Kernel code still cannot reach them. "Eval in this env" waits for the phase-6 session protocol. The status bar shows the effective capability profile and flags when it overrides the nearest project's own <IronKernelProfile> -- the extension's --profile has silently overridden the project's declaration since the setting existed, and surfacing that is most of the item's value. Selecting a profile restarts the language server so the authority shown is the authority the session environment carries. Compiled-vs-residual highlighting is the correction: CResidual almost never occurs, because the hybrid boundary is a runtime property (bodies compile on first application, ADR 0004; speed lives in binding-guard specializations), not an IR node, and located spans cover only the special-form spine. An honest coverage view needs runtime instrumentation, which belongs with phase 6. The ADR records that so the "nearly free" framing is not re-derived from the CLocated line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Phase 5 of ADR 0009 — the visible surfaces. Two of its three items ship; the third is corrected and deferred with its real dependency named.
Environment inspector
An explorer tree view fed by a custom
ironkernel/environmentLSP request: the session's capability set, the buffer's defines as the innermost frame, then every reachable frame with each binding classified (operative/applicative/value, themed icons) and its contract as tooltip detail. Frame structure stays host-side exactly as phase 2 decided — the view shows the parent chain, Kernel code still cannot reach it. Refreshes on editor switch, save, and by command; the view only appears when the server is running. "Eval in this env" deliberately waits for the phase-6 session protocol.Profile status bar
Shows the effective capability profile for the active file, and — the real value — flags when it overrides the nearest project's own
<IronKernelProfile>: the extension's--profilehas silently overridden the project declaration since the setting existed. Click to switch via QuickPick; changing it restarts the language server, so the authority displayed is the authority the server's session environment actually carries.The correction: compiled-vs-residual highlighting deferred
The plan's aside ("
CLocatedforms already mark what the analyzer touched") was true and beside the point.CResidualalmost never occurs — the hybrid compiled/interpreted boundary is not an IR node but a runtime property (bodies compile on first application per ADR 0004; performance lives in binding-guard specializations with interpreted fallbacks), and located spans exist only on the special-form spine. A truthful coverage view needs runtime instrumentation, which belongs with phase 6's session protocol. Recorded in the ADR so the "nearly free" framing doesn't get re-derived.Verification
--no-incrementalrebuild: zero warnings. Full suite: 447/447 (1 new: the environment request end-to-end — buffer frame carries thevaudefine as operative,+appears as applicative with its certified contract, capabilities includehost-io).tsc --noEmitclean, vitest 23/23 (2 new forparseProjectProfile),vsce packageproduces the VSIX.faulted (process aborted): 0.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.