Pause child resources while Device phase is not Running#362
Merged
Conversation
Previously, computeCondition only paused child resources when the Device phase was a non-empty value other than Running. A freshly created Device starts with an empty phase before the DeviceReconciler sets it to Pending/Running. During this window, children were not paused and could attempt reconciliation against a device that is not yet ready. Remove the empty-phase exclusion in computeCondition so that any phase other than Running (including empty) pauses child resources. Align DevicePausedChanged with this semantic: previously it also excluded the empty phase from its change detection, meaning the transition from "" to "Running" was invisible to the watch predicate and children were never re-triggered to unpause. Rewrite the predicate using positive-form comparisons (==) for clarity. Add a DeviceReconciler to the cisco/nx controller test suite so that test Devices automatically transition to Running when no provisioning is configured, matching production behavior. Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
felix-kaestner
force-pushed
the
fix/paused
branch
from
e804de5 to
df91338
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
hardikdr
added
the
area/switch-automation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, computeCondition only paused child resources when the Device phase was a non-empty value other than Running. A freshly created Device starts with an empty phase before the DeviceReconciler sets it to Pending/Running. During this window, children were not paused and could attempt reconciliation against a device that is not yet ready.
Remove the empty-phase exclusion in computeCondition so that any phase other than Running (including empty) pauses child resources.
Align DevicePausedChanged with this semantic: previously it also excluded the empty phase from its change detection, meaning the transition from "" to "Running" was invisible to the watch predicate and children were never re-triggered to unpause. Rewrite the predicate using positive-form comparisons (==) for clarity.
Add a DeviceReconciler to the cisco/nx controller test suite so that test Devices automatically transition to Running when no provisioning is configured, matching production behavior.