Skip to content

Add complex conjugate pair validation#163

Open
amkearns-usgs wants to merge 2 commits into
iris-edu:masterfrom
amkearns-usgs:complex-conjugate-checker
Open

Add complex conjugate pair validation#163
amkearns-usgs wants to merge 2 commits into
iris-edu:masterfrom
amkearns-usgs:complex-conjugate-checker

Conversation

@amkearns-usgs

@amkearns-usgs amkearns-usgs commented Jul 7, 2026

Copy link
Copy Markdown

Changes related to #162

I expect these changes will require further review. Due to issues with dependencies (the master branch requires java-4-seed 1.1.1-SNAPSHOT which is not on Maven) I have not been able to build/run the existing tests, and did not see any CI/automated testing setups for the codebase.

Pseudocode of this rule:

IF Stage[N]:PolesZeros is INCLUDED AND Stage[N]:PolesZeros:Zero[N]:Imaginary != 0 THEN Stage[N]:PolesZeros:Zero[M]:Imaginary == -1 * Stage[N]:PolesZeros:Zero[N]:Imaginary AND Stage[N]:PolesZeros:Zero[M]:Real == Stage[N]:PolesZeros:Zero[N]:Real
AND 
IF Stage[N]:PolesZeros is INCLUDED AND Stage[N]:PolesZeros:Pole[N]:Imaginary != 0 THEN Stage[N]:PolesZeros:Pole[M]:Imaginary == -1 * Stage[N]:PolesZeros:Pole[N]:Imaginary AND Stage[N]:PolesZeros:Pole[M]:Real == Stage[N]:PolesZeros:Pole[N]:Real

@amkearns-usgs

Copy link
Copy Markdown
Author

By doing a manual exclusion in pom.xml I was able to get a working version of java-4-seed. However, other aspects of the maven configuration seem to be out of date (especially regarding the unit test libraries and plugins) and so I continue to have issues related to parts of the code I have not touched when running all tests.

I am willing to revert to the prior pom.xml but I will probably put an issue then about problems building from source.

@rcasey-earthscope

Copy link
Copy Markdown

Hi amkearns-

We're currently in the middle of moving our assets over to AWS and we're still trying to get our housecleaning done with regards to Maven artifacts. Things did get to be a mess and we are two months out from complete shutdown of our legacy on-prem systems.

I could not find a version 1.1.1 artifact in our old Nexus Maven distro, and Maven Central last deployed a version 1.1.0 using a non-shared account. Definitely some blockers there.

The currently maintained repo is at https://github.com/EarthScope/java-4-seed. Its pom is marked version 1.1.1, but there's no currently built artifact here. That's kind of the place we're at with this. I'll post more here if we can see some incremental headway to getting public artifacts ready for maven consumption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants