crypto: Drop unused ecc declarations - #1633
Merged
Merged
Conversation
The ValueT-templated ecc::Point, the InvFn function-pointer alias and ExtFieldElem::zero() have no users: curve points are represented by AffinePoint and ProjPoint, and the zero value is spelled as default-initialization everywhere.
There was a problem hiding this comment.
Pull request overview
Removes unused internal elliptic-curve declarations without changing behavior.
Changes:
- Removed unused
ecc::Pointandecc::InvFn. - Removed unused
ExtFieldElem::zero().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/evmone_precompiles/ecc.hpp |
Removes obsolete ECC declarations. |
lib/evmone_precompiles/pairing/field_template.hpp |
Removes the unused zero factory. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1633 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 171 171
Lines 15593 15593
Branches 3606 3606
=======================================
Hits 15235 15235
Misses 269 269
Partials 89 89
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three declarations in the elliptic-curve headers have no users anywhere in the
repository, tests and tools included:
ecc::Point, theValueT-templated affine point — curve points are representedby
AffinePoint/ProjPoint. It even carried the same doc comment asAffinePoint, which is the tell that it is a leftover.ecc::InvFn, a function-pointer alias for an inversion callback.ExtFieldElem::zero()— the zero value is spelled as default-initializationeverywhere.
one()is used and stays.Deletion only, no behaviour change.