Add the ability to prioritize decorators #255

Activity

1. ipjohnson

   added

   enhancement

   on Mar 29, 2020
2. ipjohnson

   added a commit that references this issue on Apr 4, 2020

   adding priority for fluent decorators issue #255

   4bd8dcd
3. ipjohnson commented on Apr 4, 2020

   

   ipjohnson

   on Apr 4, 2020

   OwnerAuthor

   More actions

   This is implemented
4. ipjohnson

   closed this as completedon Apr 4, 2020
5. shahabganji commented on Apr 5, 2020

   

   shahabganji

   on Apr 5, 2020

   More actions

   @ipjohnson thanks for this feature 🙏

   Priority method overrides the order of decorators registrations. This is still globally ordering the decorators and one cannot customize it per implementations, right?

   Consider the following rare scenario:

   public interface ICommand<T>{
       void Handle(T data);
   }
   
   [Audit]
   [Log]
   public class FirstCommand: ICommand<string> { ... } 
   
   
   [Database]
   [Log]
   [Audit]
   public class SecondCommand: ICommand<string>{ ... }

   And there are three other decorators implementing the ICommand<T> and with .When.MeetsCondition, an example discussed earlier, they have been customized to be created on the existence of the corresponding attribute on top of the implementations. Is there any way that the order of decorators being based on the order of attributes? For instance, when creating decorators for FirstCommand the order be Audit -> Log but for the SecondCommand it should be the other way: Database -> Log -> Audit.

   is it at all possible and reasonable?

   Thanks.
6. ipjohnson commented on Apr 5, 2020

   

   ipjohnson

   on Apr 5, 2020

   OwnerAuthor

   More actions

   Sadly attribute order is not preserved as part of the language specification.

   "The order in which attributes are specified in such a list, and the order in which sections attached to the same program entity are arranged, is not significant. For instance, the attribute specifications [A][B], [B][A], [A,B], and [B,A] are equivalent."

   👍React with 👍1Reacted by Shahab Ganji