ExportDecorator with When.InjectedInto won't fire #192

Activity

1. ipjohnson

   added

   bug

   on Aug 31, 2018
2. ipjohnson commented on Aug 31, 2018

   

   ipjohnson

   on Aug 31, 2018

   Owner

   More actions

   @mgth I was able to replicate the bug. I'll see if I can fix it this weekend at some point and do a beta release.
3. ipjohnson

   added a commit that references this issue on Aug 31, 2018

   fixing logic ignore wrappers when considering When. condition for issue

   ...

   0e85552
4. ipjohnson commented on Sep 2, 2018

   

   ipjohnson

   on Sep 2, 2018

   Owner

   More actions

   @mgth I've released a pre-release version to nuget. Can you test it out?
5. mgth commented on Sep 2, 2018

   

   mgth

   on Sep 2, 2018

   Author

   More actions

   Sorry, it still fail for me. But this is special case where I must use Container.Inject(obj);
   Another thing is the decorator itself does not get injected.
6. ipjohnson commented on Sep 2, 2018

   

   ipjohnson

   on Sep 2, 2018

   Owner

   More actions

   @mgth you’ll need to put together a sample showing the issue.
7. mgth commented on Sep 3, 2018

   

   mgth

   on Sep 3, 2018

   Author

   More actions

       interface IService { }
       class MyService : IService { }
       class MyServiceDecorator : IService { }
   
       interface IMyClass { }
       class MyClass : IMyClass
       {
           [Import]
           public Func<IService> GetService { get; set; }
       }
   
       class Program
       {
           static void Main(string[] args)
           {
               var container = new DependencyInjectionContainer();
   
               container.Configure( c =>
               {
                   c.Export<MyClass>().As<IMyClass>().ImportMembers();
                   c.Export<MyService>().As<IService>();
                   c.ExportDecorator(typeof(MyServiceDecorator)).As(typeof(IService)).When.InjectedInto<IMyClass>();
               });
   
               var myClass = new MyClass();
               container.Inject(myClass);
   
               // there getService will return a MyService when it should return a MyServiceDecorator
               var service = myClass.GetService();
           }
       }
   

   when this will return a MyServiceDecorator as expected
   var myClass = (MyClass)container.Locate<IMyClass>();
8. ipjohnson

   added a commit that references this issue on Sep 3, 2018

   adding custom when condition issue #192

   682dc92
9. ipjohnson commented on Sep 3, 2018

   

   ipjohnson

   on Sep 3, 2018

   Owner

   More actions

   @mgth the reason it's not work the way you want it to is because the Inject method is an extension and isn't a first class feature in the container. No strategy is created for an injected type so the default implementation for WhenInjectedInto won't work.

   I'm not inclined to make a change to the default behavior because it could have unintended side effects but you could do a custom condition like this.
10. mgth commented on Sep 3, 2018

    

    mgth

    on Sep 3, 2018

    Author

    More actions

    Ok, that works. Thank you much for your precious time.
11. ipjohnson commented on Sep 3, 2018

    

    ipjohnson

    on Sep 3, 2018

    Owner

    More actions

    @mgth glad I was able to address your issue. I'm going to close this as fixed, if you run into anything more open an issue and I'll try and address it.

    I'll plan on doing an official release near the end of this month.
12. ipjohnson

    closed this as completedon Sep 3, 2018