⚡ Bolt: Optimize handleAgentEvents tracking to prevent O(N*M) overhead#110
⚡ Bolt: Optimize handleAgentEvents tracking to prevent O(N*M) overhead#110iotserver24 wants to merge 2 commits into
Conversation
- Pre-computes streaming and pending tool call indices before iterating over the incoming batch of HostedAgentEvent array. - Dynamically updates the stored indices during iteration instead of running full array scans. - Ensures the state array operations remain O(N+M) instead of O(N*M).
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Hey @iotserver24! 👋 I'll go through the changes and help you out with an automated review! 🔍 Starting the review now... |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- The previous commit optimizing `handleAgentEvents` was blocked by a CI check that runs `pnpm audit --audit-level=high`. - CI was failing because of high severity vulnerabilities in `tmp` and `axios`. - Added an override in `package.json` to force `axios@^1.16.0` and `tmp@^0.2.6` to mitigate these dependencies globally.
1 participant
💡 What: Optimized
handleAgentEventsinpackages/desktop/src/renderer/App.tsxby pre-computing indices for the last assistant streaming message and the last pending tool call before processing the event batch. The cached indices are dynamically updated during iteration instead of rescanning the array.🎯 Why: Previously, the code performed an O(N) backward search (
findLastAssistantStreamingandfindLastToolCall) for every single event in an incoming batch (Mevents). This created a severe O(N*M) performance bottleneck, causing UI micro-stutters when handling large chat histories and rapid streaming events.📊 Impact: Reduces batch event processing time complexity from O(N*M) down to O(N + M). This eliminates UI blocking during intense streaming and batch tool call resolutions for long conversations.
🔬 Measurement: Verify the optimization by loading a session with a massive chat history (> 50 messages), triggering an LLM response or tool execution, and observing the lack of rendering latency / frame drops compared to the main branch. Alternatively, one could run a local profile using React DevTools during a stream.
PR created automatically by Jules for task 3656302330355763086 started by @iotserver24