Fix reconnect case label in start_remote_debug_server - #609
Open
zHElEARN wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a typo in
start_remote_debug_serverwherecase 0x800002d:was used instead ofcase 0xe800002d:. This prevented the reconnect mechanism from being triggered when the device lost connection during service start.When running
ios-deploywith--nolldb, startingdebugservercan sometimes fail with error0xe800002d(Could not send a message to the device).Although the code comment in
start_remote_debug_serverexplicitly notes:The
switch(start_err)block incorrectly checked forcase 0x800002d:. Because of missing the leadinge,0xe800002dfell through to thedefault:case, triggering a fatal error rather than executing the recovery logic.Fix
Updated
case 0x800002d:tocase 0xe800002d:insrc/ios-deploy/ios-deploy.mto properly catch the error and reconnect to the device as intended.