Repository navigation
chore(ci): run on node 26 from .nvmrc and name the test jobs by os - #91
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShaneK
approved these changes
Nov 11, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This Does
Moves all of CI to Node 26, reads the version from
.nvmrc, and names the Test jobs by OS only, so a future Node update is a one-line Renovate PR that doesn't rename the required status checks.New Behavior
nvm use(or fnm) picks up Node 26 locally.Changes
.nvmrcwith26. Everyactions/setup-nodestep reads it withnode-version-file, inCI.ymlandcapacitor-sync.yml, and the steps are named "Set up Node.js" without a version..github/workflows/CI.yml:node_versionmatrix. Renovate didn't update the matrix, so its Node 26 update left the Test jobs on 24.concurrencygroup per pull request, withcancel-in-progress, so outdated runs don't queue up behind new ones.@types/node24 → 26, and removes the Renovate rule that capped it to the CI Node version. It's only used forprocess.envinplaywright.config.ts, so it can follow the latest release.Notes
main: replace "Test on node 24 and macOS-latest" and "Test on node 24 and windows-latest" with "Test on macOS-latest" and "Test on windows-latest"..nvmrcwhen a new Node version is released, which moves every job at once.