Skip to content

chore(ci): run on node 26 from .nvmrc and name the test jobs by os - #91

Merged
brandyscarney merged 3 commits into
mainfrom
chore/ci-node-26
Nov 11, 2026
Merged

brandyscarney merged 3 commits into
mainfrom
chore/ci-node-26

Conversation

@brandyscarney

@brandyscarney brandyscarney commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

What This Does

Moves all of CI to Node 26, reads the version from .nvmrc, and names the Test jobs by OS only, so a future Node update is a one-line Renovate PR that doesn't rename the required status checks.

New Behavior

  • Every CI job runs on Node 26, the current LTS. The Test jobs were still on Node 24.
  • The Test jobs are named Test on macOS-latest and Test on windows-latest.
  • Pushing a new commit to a pull request cancels its CI run that's still in progress.
  • nvm use (or fnm) picks up Node 26 locally.

Changes

  • Adds .nvmrc with 26. Every actions/setup-node step reads it with node-version-file, in CI.yml and capacitor-sync.yml, and the steps are named "Set up Node.js" without a version.
  • .github/workflows/CI.yml:
    • The Test job drops its one-item node_version matrix. Renovate didn't update the matrix, so its Node 26 update left the Test jobs on 24.
    • The Test job name drops the Node version, along with the comment about updating branch protection on each Node update.
    • A concurrency group per pull request, with cancel-in-progress, so outdated runs don't queue up behind new ones.
  • @types/node 24 → 26, and removes the Renovate rule that capped it to the CI Node version. It's only used for process.env in playwright.config.ts, so it can follow the latest release.

Notes

  • Before merging, update the required status checks on main: replace "Test on node 24 and macOS-latest" and "Test on node 24 and windows-latest" with "Test on macOS-latest" and "Test on windows-latest".
    • ✅ This has been done
  • Renovate updates .nvmrc when a new Node version is released, which moves every job at once.
  • Matches the conference apps' CI.

@brandyscarney
brandyscarney requested a review from a team as a code owner November 11, 2026 20:33
@brandyscarney
brandyscarney requested review from thetaPC and removed request for a team November 11, 2026 20:33
@vercel

vercel Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tutorial-photo-gallery-react Ready Ready Preview Nov 11, 2026 9:06pm UTC

Request Review

@brandyscarney brandyscarney changed the title chore(ci): run every job on node 26 and name the test jobs by os chore(ci): run on node 26 from .nvmrc and name the test jobs by os Nov 11, 2026
@brandyscarney
brandyscarney merged commit 665a368 into main Nov 11, 2026
6 checks passed
@brandyscarney
brandyscarney deleted the chore/ci-node-26 branch November 11, 2026 21:51

This branch was successfully deployed

1 active deployment
Preview — 2c05ff7d Deployed Nov 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants