Skip to content

test: cover the tutorial, schedule, sessions, speakers, and account flows - #195

Draft
brandyscarney wants to merge 2 commits into
chore/add-test-infrastructurefrom
chore/add-test-coverage
Draft

brandyscarney wants to merge 2 commits into
chore/add-test-infrastructurefrom
chore/add-test-coverage

Conversation

@brandyscarney

@brandyscarney brandyscarney commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

What This Does

Adds tests for the app's features: the tutorial, the schedule (search, favorites, and track filters), session and speaker details, login, signup, and the account page, and navigation to every page.

New Behavior

  • The unit tests cover the selectors, reducers, actions, and data loading, and render the main pages and components with preset state.
  • The e2e tests run every user flow in the app in Mobile Chrome, and check that state that's meant to persist (the tutorial, login, username) survives a reload.

Changes

  • AppContextProvider takes an optional initialState, so tests can render pages with preset state without starting the whole app. The app still starts from the default state.
  • e2e/tutorial.spec.ts (replaces e2e/app.spec.ts): the tutorial shows on the first visit; Skip opens the schedule; scrolling through the slides and tapping Continue opens the schedule; once it's done, reloading / goes straight to the schedule; the menu can show the tutorial again.
  • e2e/schedule.spec.ts: sessions are grouped and sorted by time; search filters by name, clearing it restores the list, and no matches shows an empty state; Favorites shows its empty state, or only the favorited sessions; the filter excludes a track and including it again brings its sessions back; Reset clears every track.
  • e2e/session-detail.spec.ts: the detail page shows the title, track, time, and location; favoriting and unfavoriting from the detail page; favoriting and removing with a swipe, including the toast and the confirm alert.
  • e2e/speakers.spec.ts: speakers are listed with their sessions; a speaker opens their detail page; a session on a speaker's card opens its detail page.
  • e2e/account.spec.ts: starts logged out; login requires a password; login switches the menu to Account/Logout and survives a reload; the Account page shows the username and changes it (still changed after a reload); logout is saved; signup logs the user in; Login links to Signup.
  • e2e/navigation.spec.ts: the tab bar and the menu reach every page with its title; the map shows a marker per location, with tile requests blocked so it doesn't need the network; the Support form sends a message and refuses an empty one; the dark mode toggle switches ion-palette-dark.
  • e2e/helpers.ts: shared locators and steps.
  • src/data/selectors.test.ts: time sorting (including 12 am/pm), the track filter, search, favorites, finding sessions and speakers, each speaker's sessions, and the map center.
  • src/data/state.test.ts: every reducer and the combined reducer.
  • src/data/actions.test.ts: the load actions, the actions that save to storage, and the map locations with their fallback.
  • src/data/dataApi.test.ts: loading the conference data from the real data files, and saving user data with Preferences stubbed.
  • Menu, HomeOrTutorial, SchedulePage, SessionDetail, and SpeakerList tests render with preset state.
  • src/testing/fixtures.ts and src/testing/render.tsx: test fixtures and a render helper (provider and router).

Notes

  • 40 e2e tests and 63 unit tests. The e2e suite passed 120 of 120 runs locally (--repeat-each=3), including at 8 workers.
  • 12 pieces of logic were broken one at a time (search, track exclusion, the Favorites filter, adding and removing a favorite, saving login, the tutorial-done flag, pm time sorting, speaker sessions, logout, dark mode, changing the username), and each one failed a test.
  • The favorite, share, search, and filter buttons have no accessible names, so the tests find them by their position in the toolbar.
  • App bugs found while writing the tests are tracked separately; none of them are fixed here.

@vercel

vercel Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ionic-react-conference-app Ready Ready Preview Nov 11, 2026 10:46pm UTC

Request Review

@brandyscarney
brandyscarney added this pull request to stack #185 November 11, 2026 22:34

This branch was successfully deployed

1 active deployment
Preview — bb324ceb Deployed Nov 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant